Repository navigation
Add team-repo-admins that are also in infra to CODEOWNERS - #2964
Open
marcoienibot wants to merge 1 commit into
Open
marcoienibot wants to merge 1 commit into
marcoienibot wants to merge 1 commit into
Conversation
Dry-run check results |
Co-authored-by: marcoienibot <206998110+marcoienibot@users.noreply.github.com>
marcoieni
force-pushed
the
t3/include-infra-admins-codeowners
branch
from
November 19, 2026 08:52
74c86be to
d2ba8fe
Compare
marcoieni
reviewed
Nov 19, 2026
| .explicit_members() | ||
| .iter() | ||
| .map(|m| m.github.as_str()) | ||
| .collect::<BTreeSet<_>>() |
Member
There was a problem hiding this comment.
use BTreeSet to have sorting and deduplication.
marcoieni
marked this pull request as ready for review
November 19, 2026 09:07
marcoieni
requested review from
Mark-Simulacrum,
emilyalbini,
jdno and
ubiratansoares
as code owners
November 19, 2026 09:07
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #t-infra > more reviewers for the team repo we want more reviewers.
Code owners admins are now:
infra-admins(as before), plusteam-repo-adminswho are also direct members of theinfrateam.With the current data, this adds
@jieyouxuto every owner rule in.github/CODEOWNERS.