Repository navigation
Add r? @ghost on Josh push PRs - #2275
Merged
Merged
Conversation
Collaborator
|
r? @folkertdev rustbot has assigned @folkertdev. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Contributor
|
I'd prefer to keep it, we generally self-approve the sync PRs, no need to ping someone else? |
Member
Author
|
Yeah, I think it makes sense :) |
Contributor
|
I'll just merge then, we can change it later if others feel strongly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to remove this suffix from push PRs by default, but that would be a "breaking change" in the PR description (rust-lang/josh-sync#79).
If you want to keep the suffix, you can merge this PR. Otherwise, I can close it, and the suffix will disappear once the linked PR gets merged.