Skip to content

Add r? @ghost on Josh push PRs - #2275

Merged
folkertdev merged 1 commit into
rust-lang:mainfrom
Kobzol:josh-push-msg
Nov 18, 2026
Merged

folkertdev merged 1 commit into
rust-lang:mainfrom
Kobzol:josh-push-msg

Conversation

@Kobzol

@Kobzol Kobzol commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

We want to remove this suffix from push PRs by default, but that would be a "breaking change" in the PR description (rust-lang/josh-sync#79).

If you want to keep the suffix, you can merge this PR. Otherwise, I can close it, and the suffix will disappear once the linked PR gets merged.

@rustbot

rustbot commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator

r? @folkertdev

rustbot has assigned @folkertdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @Amanieu, @adamgemmell, @davidtwco, @folkertdev
  • @Amanieu, @adamgemmell, @davidtwco, @folkertdev expanded to Amanieu, adamgemmell, davidtwco, folkertdev
  • Random selection from Amanieu, adamgemmell, davidtwco, folkertdev

@folkertdev

Copy link
Copy Markdown
Contributor

I'd prefer to keep it, we generally self-approve the sync PRs, no need to ping someone else?

@Kobzol

Kobzol commented Nov 18, 2026

Copy link
Copy Markdown
Member Author

Yeah, I think it makes sense :)

@folkertdev

Copy link
Copy Markdown
Contributor

I'll just merge then, we can change it later if others feel strongly.

@folkertdev
folkertdev enabled auto-merge November 18, 2026 19:07
@folkertdev
folkertdev added this pull request to the merge queue Nov 18, 2026
Merged via the queue into rust-lang:main with commit ca26a96 Nov 18, 2026
87 checks passed
@Kobzol
Kobzol deleted the josh-push-msg branch November 18, 2026 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants