Skip to content

libcore: Revert some comment changes - #166269

Open
GuillaumeGomez wants to merge 1 commit into
rust-lang:mainfrom
GuillaumeGomez:revert-comment-changes
Open

GuillaumeGomez wants to merge 1 commit into
rust-lang:mainfrom
GuillaumeGomez:revert-comment-changes

Conversation

@GuillaumeGomez

Copy link
Copy Markdown
Member

As asked here.

r? @RalfJung

@rustbot rustbot added A-panic Area: Panicking machinery S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 20, 2026
@rustbot

rustbot commented Nov 20, 2026

Copy link
Copy Markdown
Collaborator

RalfJung is not on the review rotation at the moment.
They may take a while to respond.

Comment thread library/core/src/panicking.rs Outdated
#[inline]
#[track_caller]
#[rustc_diagnostic_item = "unreachable_display"]
#[rustc_diagnostic_item = "unreachable_display"] // needed for `non-fmt-panics`

@RalfJung RalfJung Nov 20, 2026 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#[rustc_diagnostic_item = "unreachable_display"] // needed for `non-fmt-panics`
#[rustc_diagnostic_item = "unreachable_display"] // needed for `non-fmt-panics` lint

Or is there a reason you removed that word?

View changes since the review

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no clue how I removed it. ^^'

@RalfJung

Copy link
Copy Markdown
Member

Thanks!

r=me with or without the nit

@GuillaumeGomez

Copy link
Copy Markdown
Member Author

@bors r=RalfJung rollup

@rust-bors

rust-bors Bot commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

📌 Commit e01e4a6 has been tentatively approved by RalfJung

It will be put into the queue for this repository once PR CI succeeds.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 20, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Nov 20, 2026
rust-bors Bot pushed a commit that referenced this pull request Nov 20, 2026
…uwer

Rollup of 5 pull requests

Successful merges:

 - #166266 (miri subtree update)
 - #164878 (Don't require `extern "llvm-intrinsic"` return structs to be `#[repr(packed)]`)
 - #165930 (Add red-green mark when dumping dep graph. Show DefIds if available)
 - #166012 (Added more queries to AdtDef in rustc_public to check for rust language types)
 - #166269 (libcore: Revert some comment changes)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-panic Area: Panicking machinery S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants