Skip to content

add new read_chars method, incidentally fix bug in old read_char method - #1468

Closed
grahame wants to merge 3 commits into
rust-lang:masterfrom
grahame:master
Closed

grahame wants to merge 3 commits into
rust-lang:masterfrom
grahame:master

Conversation

@grahame

@grahame grahame commented Jan 8, 2012

Copy link
Copy Markdown

having a read_chars method is convenient and more efficient.
the old read_char method had a bug due to re-use of the 'w' width variable as a loop counter and so was broken for wide characters, this patch fixes that.

(I cancelled the last pull request as I tidied the code up further.)

Grahame Bowland added 3 commits January 8, 2012 03:02
This change also fixes a bug in the old read_char method with
multi-byte utf8 characters, due to re-use of 'w' variable as a loop
counter.
@grahame grahame closed this Jan 8, 2012
Kobzol pushed a commit to Kobzol/rust that referenced this pull request Dec 30, 2024
bors pushed a commit to rust-lang-ci/rust that referenced this pull request Jan 2, 2025
U007D pushed a commit to U007D/rust-mos that referenced this pull request Aug 21, 2026
1468: Use inline snapshots in complete_path r=matklad a=funkill

Relates to rust-lang#1127 

Co-authored-by: funkill2 <funkill2@gmail.com>
U007D pushed a commit to U007D/rust-mos that referenced this pull request Aug 21, 2026
Test uninit memory validation

This adds the tests for rust-lang#74059.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant