Repository navigation
Change intrinsic declarations to new style - #132907
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @RalfJung (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
|
Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter cc @rust-lang/miri, @rust-lang/wg-const-eval |
|
Sorry if the changes looks a little messy , I have changed the first block or extern "intrinsic" to new delaration as its quite time consuming I wanted to confirm first if its fine. Then I can proceed with other blocks |
This comment has been minimized.
This comment has been minimized.
|
Thanks for the PR!
I'm quite busy currently and will try to get back to you next weekend.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
I think the CI failures are because you deleted |
|
yeah I guess I will git reset and begin again . |
This comment has been minimized.
This comment has been minimized.
|
I would recommend removing the |
This comment has been minimized.
This comment has been minimized.
ca3c94c to
81eef2d
Compare
|
GitHub doesn't let you reopen a PR once you've force-pushed to it. If you reset the branch to the commit before the force-push, I believe it will let you reopen it. (that commit would be ca3c94c) |
|
? Was I wrong? That would be very cool if I was wrong. |
I just pushed new changes and reopened , git sometimes get confusing I forced pushed the latest commit of the main repo so there was no change in files so it closed. I don't think force push closes the pr I have done it once before and pr was still open I am not sure though . Anyways I have build the repo on my system and it showed no error I hope it does same here |
|
also I used x.py fmt Idk how it works but some function parameters are on different lines while others are in single line, kind of weird is it fine or I have to change that ? |
|
Whatever |
This comment has been minimized.
This comment has been minimized.
|
It looks like its fine now, sorry for trouble I will make sure it won't happen again. |
|
Please wait until this PR landed before making the next one. :) Which part of #132735 does this cover? Does it do all of |
I wasn't I was just asking also Its just a part I think there are 2 more |
|
Okay, sounds good! Someone should take a close look at the first part before you repeat the same process for the remaining intrinsics, so it's better to wait for now. |
There's no need to apologize. Making mistakes is a normal part of development and review, that's why we have tests and reviewers. Looks good! r? saethlin |
…kingjubilee Rollup of 7 pull requests Successful merges: - rust-lang#131304 (float types: move copysign, abs, signum to libcore) - rust-lang#132907 (Change intrinsic declarations to new style) - rust-lang#132971 (Handle infer vars in anon consts on stable) - rust-lang#133003 (Make `CloneToUninit` dyn-compatible) - rust-lang#133004 (btree: simplify the backdoor between set and map) - rust-lang#133008 (update outdated comment about test-float-parse) - rust-lang#133012 (Add test cases for rust-lang#125918) r? `@ghost` `@rustbot` modify labels: rollup
commented
Nov 14, 2024
|
Oh sorry for late response I was busy with my college , so like this pr is merged so I have to make separate pr for other parts for changes right? |
commented
Nov 14, 2024
|
You don't have to, but if you want to continue working on it that would be the next step. :) |
Pr is for issue #132735
This changes the first
extern "rust-intrinsic"block to the new style.r? @RalfJung