You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
regression: reached recursion limit while instantiating #79909
searched nightlies: from nightly-2020-10-23 to nightly-2020-12-12
regressed nightly: nightly-2020-10-28
searched commits: from fd54259 to 07e968b
regressed commit: a4d30a7
Underneath the recursion limit error lies a success story. The combine crate generates a lot of dead code and a new implementation is much better at removing it. The most significant aspect is removal of dead dyn casts, since without them there are fewer codegen items.
The crate has a configured recursion limit 67, which is exactly what is necessary. Since the codegen item collector uses memoization, removal of dyn cast might increase required recursion depth, which after changes it is at 71.
I am inclined to agree that this is not readily fixable. I am not sure whether we made the right call exposing such internal implementation details to end users - it feels like recursion limits are always going to be error prone for people to configure. However, the limit of 67 configured by this crate is below the minimum Rust by default sets (128 currently) so I am not inclined to be too worried.
cc @hirartara as the author of this regressed crate
I made that crate before only to practice Rust, and it has almost no content. Therefore, we don't need to worry at all if we can't build this crate.
Moreover, as far as I remember, the default value of recursion_limit was 64 when I created this crate. Now, I can build the crate if I delete the recursion_limit annotation.
Activity
dillona commentedon Dec 12, 2020
searched nightlies: from nightly-2020-10-23 to nightly-2020-12-12
regressed nightly: nightly-2020-10-28
searched commits: from fd54259 to 07e968b
regressed commit: a4d30a7
bisected with cargo-bisect-rustc v0.6.0
Host triple: aarch64-unknown-linux-gnu
Reproduce with:
Mark-Simulacrum commentedon Dec 12, 2020
cc @tmiasko -- any idea how #77876 could cause that? It seems quite unexpected to me but maybe I'm missing something
tmiasko commentedon Dec 12, 2020
Underneath the recursion limit error lies a success story. The combine crate generates a lot of dead code and a new implementation is much better at removing it. The most significant aspect is removal of dead dyn casts, since without them there are fewer codegen items.
The crate has a configured recursion limit 67, which is exactly what is necessary. Since the codegen item collector uses memoization, removal of dyn cast might increase required recursion depth, which after changes it is at 71.
Mark-Simulacrum commentedon Dec 12, 2020
Hm, and 67 is lower than the default? I am a bit worried at us exposing such low level details, but it sounds like this should be won't fix.
apiraino commentedon Dec 16, 2020
Discussed on Zulip and removing
I-prioritizeMark-Simulacrum commentedon Dec 18, 2020
I am inclined to agree that this is not readily fixable. I am not sure whether we made the right call exposing such internal implementation details to end users - it feels like recursion limits are always going to be error prone for people to configure. However, the limit of 67 configured by this crate is below the minimum Rust by default sets (128 currently) so I am not inclined to be too worried.
cc @hirartara as the author of this regressed crate
wesleywiser commentedon Dec 18, 2020
@Mark-Simulacrum I think you meant to cc @hiratara
hiratara commentedon Dec 19, 2020
Hello,
I made that crate before only to practice Rust, and it has almost no content. Therefore, we don't need to worry at all if we can't build this crate.
Moreover, as far as I remember, the default value of
recursion_limitwas64when I created this crate. Now, I can build the crate if I delete therecursion_limitannotation.Mark-Simulacrum commentedon Dec 27, 2020
Closing as won't fix.