Repository navigation
Conversation
The component container and the node_main template declared the executor first, so it was destroyed last, after the component libraries were unloaded. An executor still holding references to component entities then released them into unloaded code, e.g. the EventsCBGExecutor crashed on Ctrl-C. Declare the executor after the component manager and the class loader, so it is destroyed first. Signed-off-by: Vojtech Spurny <spurny@fly4future.com> Assisted-by: Claude Code:claude-opus-5-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
component_containerandnode_main.cpp.indeclare the executor first, so it is destroyed after the component libraries are unloaded.EventsCBGExecutorstill holds references to component entities at that point and crashes on Ctrl-C (#3312). The executor is now declared after the manager / loader, so it is destroyed first.Suggested by @jmachowinski in #3313.
Is this user-facing behavior change?
No.
Did you use Generative AI?
Assisted-by: Claude Opus 5.5
Additional Information