Repository navigation
Remove libstatistics_collector from rclcpp QUALITY_DECLARATION - #3316
Merged
jmachowinski merged 1 commit intoOct 7, 2026
Conversation
Topic statistics were removed in #3203, which dropped the libstatistics_collector and statistics_msgs dependencies from package.xml and CMakeLists.txt. The statistics_msgs section of the quality declaration was removed at the same time, but the libstatistics_collector section was left behind. Remove it so the declared runtime dependencies match the actual ones. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Tomoya Fujita <fujita.tomoya@triorb.co.jp>
fujitatomoya
commented
Oct 7, 2026
fujitatomoya
left a comment
Collaborator
Author
There was a problem hiding this comment.
@jmachowinski can you take a look and merge? i do not think we need CI for this.
jmachowinski
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Topic statistics were removed in #3203, which dropped the libstatistics_collector and statistics_msgs dependencies from package.xml and CMakeLists.txt. The statistics_msgs section of the quality declaration was removed at the same time, but the libstatistics_collector section was left behind. Remove it so the declared runtime dependencies match the actual ones.
Description
leftover from #3203
Fixes # (issue)
Is this user-facing behavior change?
No
Did you use Generative AI?
Yes, Claude Fable 5.1
Additional Information