Repository navigation
fix(deps): backport security fixes to 1.2 for 1.2.1 - #1507
Merged
Merged
Conversation
Bumps the docker-images group with 1 update in the /hma directory: facebook/threatexchange/hma. Updates `facebook/threatexchange/hma` from 1.2.0 to 1.2.1 --- updated-dependencies: - dependency-name: facebook/threatexchange/hma dependency-version: 1.2.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: docker-images ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit ac8e913)
Bumps [storybook](https://github.com/storybookjs/storybook/tree/HEAD/code/core) from 9.1.20 to 9.1.21. - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/v9.1.21/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v9.1.21/code/core) --- updated-dependencies: - dependency-name: storybook dependency-version: 9.1.21 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit 524de27)
Bumps the npm-prod-security group with 1 update in the / directory: [markdown-it](https://github.com/markdown-it/markdown-it). Updates `markdown-it` from 14.3.2 to 14.3.3 - [Changelog](https://github.com/markdown-it/markdown-it/blob/14.3.3/CHANGELOG.md) - [Commits](markdown-it/markdown-it@14.3.2...14.3.3) --- updated-dependencies: - dependency-name: markdown-it dependency-version: 14.3.3 dependency-type: indirect dependency-group: npm-prod-security ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit 7fee15a)
…1457) Lockfile-only refresh: - follow-redirects 1.16.0 -> 1.16.1 (GHSA-8r9p-f939-6h3c, GHSA-q3jh-wrc6-jgq8) - markdown-it 14.3.2 -> 14.3.3 (GHSA-gfr2-rv44-r23c, GHSA-vfgh-jcmw-g37q) Co-authored-by: claude-agent <claude-agent@devserver.reitblatt.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit a0f504f)
* [HMA] Update image reference due to org name change * rename other references in docs (cherry picked from commit d972d45)
Co-authored-by: Claude <noreply@anthropic.com> (cherry picked from commit be861db)
…1503) * docs: point create-react-app link at react org and log HMA image fix create-react-app moved from facebook/ to react/, not meta/, so the link rewritten in #1498 404s. Also add the missing CHANGELOG entry for the HMA base image move, since 1.2.0 ships the dead ghcr.io/facebook path. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * build(hma): pin base image by digest Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: claude-agent <claude-agent@devserver.reitblatt.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 547fcdc)
Takes the undici update from #1464 (the npm-prod group) without the group's other, non-security updates. Same specifier and version as main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
reitblatt
force-pushed
the
reitblatt/backport-1.2.1-security
branch
from
October 31, 2026 01:28
f4c6102 to
71375c1
Compare
reitblatt
marked this pull request as ready for review
October 31, 2026 01:34
1 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context & Requests for Reviewers
Instead of cutting the patch release directly from main, I'm creating a patch branch off of the
1.2.0release tag, and cherry-picking just the security PRs. This is more work up front, but it makes the patch release a true patch release (lot of changes in main this week!), and when we move to regular security releases, this is the 'right' way (please, debate me!).Each commit is a cherry-pick of a merged PR from
main, except where noted:be861dbf), for CVE-2026-111181ghcr.io/facebooktoghcr.io/meta/threatexchange/hma:1.2.1, pinned by digest (Bump the "docker-images" group with 1 update across multiple ecosystems #1452, [HMA] Update image reference due to org name change #1498, fix(hma): pin meta hma image by digest and fix create-react-app link #1503)CHANGELOG.md:## [1.2.1]section and compare linksEvery package version this changes from 1.2.0 is the version
mainhas. The only lockfile conflict was express's dependency list inbe861dbf, which was resolved to keep 1.2.0's express 5.2.1 with body-parser 2.4.0.pnpm installleaves the result unchanged. The @storybook/react bumps in #1463 aren't included; the storybook fix is in #1458.Not backported: the @tiptap/core 2.x advisory. There's no patched 2.x release, and
mainfixed it with the TipTap v3 migration (#1400), which is more than I'm comfortable pulling into a patch release ATM.Tests
pnpm install --frozen-lockfile && pnpm run prettier: passpnpm run generateleaves the tree clean: passtypecheck,lint,build: passlint,build: passpnpm --filter client test: 307 passed, 2 skippeddocker compose run --rm --build test: 129 files, 1294 tests passed, 7 skipped, 1 tododocker build hma/pulls the pinned digest and buildspnpm audit: no advisories thatmainhas fixed remain, apart from tiptap as explained above(Optional) Rollout Plan
After merge, tag
1.2.1fromrelease/1.2and publish the release. Then forward-port the## [1.2.1]changelog section tomain.Checklist
Only check items that apply to this PR; leave the rest unchecked.
If you changed anything user-facing (i.e. user interface or APIs):
Did you update related docs?
If the change is notable (refer to Keep a Changelog conventions):
Did you update CHANGELOG.md?
If you changed
db/src/scripts/**and usedCREATE TABLE,ADD COLUMN, orALTER COLUMN:Are as many columns marked
NOT NULLas possible? If some columns can sometimes be null depending on other columns, are thereCHECKconstraints capturing those relationships, and are these also reflected using unions in the associated Kysely types?If you added a new signal in
server/services/signalsService/signals/**:Did you classify every error case as a permanent error (
SignalPermanentError, no retry) or a normal error (retryable)? Any case where the signal can't determine a score should be aSignalPermanentError.