Repository navigation
Fix stale TSF candidate UI after host-terminated composition - #1956
Merged
Merged
Conversation
Member
|
@fxliang 梁老師研究一下? |
Contributor
Author
|
这个 Bug 是用屏幕阅读器暴露出来的。 |
Member
|
感謝兩位積極修復! |
2 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the DirectComposition candidate UI implementation introduced by PR #1927, when a popup or dialog takes focus during an active composition, the TSF host may terminate the composition before Weasel processes the focus loss. In the captured trace,
CompositionTerminatedis reported first, and_pCompositionis already null whenOnKillThreadFocusruns.OnCompositionTerminated()clears_pComposition, so the subsequent_AbortComposition()cannot enter_EndComposition(). Before this fix, it only calledCandidateList::Destroy(), which hid and destroyed the candidate window without callingITfUIElementMgr::EndUIElement(). The TSF candidate UI therefore remained registered with_uiStarted == true, allowing later updates to reach the obsolete element. A screen reader could consequently continue to report the previous candidate content after the composition had ended.When
_AbortComposition()finds that the composition pointer is already gone, this fix callsCandidateList::EndUI()before the existing window cleanup. This ends the registered TSF UI element, resets_uiStarted, and leaves the normal active-composition path unchanged.