Skip to content

Upgrade yaml-cpp to 0.9.0 and leveldb to latest - #1250

Merged
ksqsf merged 2 commits into
rime:masterfrom
Bambooin:dependency-upgrade
Oct 25, 2026
Merged

ksqsf merged 2 commits into
rime:masterfrom
Bambooin:dependency-upgrade

Conversation

@Bambooin

@Bambooin Bambooin commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Description

There are build warnings in Trime project with the outdated librime dependencies.

> Task :app:configureCMakeRelWithDebInfo[x86_64]
C/C++: CMake Deprecation Warning at librime/deps/leveldb/CMakeLists.txt:5 (cmake_minimum_required):
C/C++:   Compatibility with CMake < 3.10 will be removed from a future version of
C/C++:   CMake.
C/C++:   Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
C/C++:   to tell CMake that the project requires at least <min> but has been updated
C/C++:   to work with policies introduced by <max> or earlier.
C/C++: 

> Task :app:buildCMakeRelWithDebInfo[x86_64]
C/C++: ninja: Entering directory `~/github/trime/app/.cxx/RelWithDebInfo/2a691u42/x86_64'
C/C++: In file included from ~/github/trime/app/src/main/jni/librime/deps/yaml-cpp/src/fptostring.cpp:2:
C/C++: ~/github/trime/app/src/main/jni/librime/deps/yaml-cpp/src/contrib/dragonbox.h:4026:32: warning: 'constexpr' non-static member function will not be implicitly 'const' in C++14; add 'const' to avoid a change in behavior [-Wconstexpr-not-const]
C/C++:  4026 |                 constexpr bool operator()(...) noexcept { return fal

Let's update these two dependencies, these warnings are gone within Trime.

  • chore: upgrade yaml-cpp to 0.9.0
  • chore: upgrade leveldb to latest commit
Dependency Before After Note
yaml-cpp 0.8.0-74-g2f86d13 (2f86d137) 0.9.0 (56e3bb55) Use the latest tag.
leveldb 1.23 (99b3c03b) 1.23-93-gbb74ef7 (bb74ef73) This repository is receiving very limited maintenance, let's use the latest commit.

I had verified with Trime and use it daily, no issue found so far.

Checklist

  • I have added or updated tests where appropriate.
  • I have manually tested the changes where appropriate.
  • I have updated relevant documentation where appropriate.
  • I have either not used AI tools or carefully reviewed their outputs, and I take full responsibility for the submitted changes and the PR description.

Additional information

@ksqsf
ksqsf merged commit 9527d75 into rime:master Oct 25, 2026
11 checks passed
@Bambooin
Bambooin deleted the dependency-upgrade branch October 25, 2026 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants