Repository navigation
Declare mz_version() even when MINIZ_NO_ZLIB_APIS is defined - #395
Merged
uroni merged 1 commit intoNov 8, 2026
Merged
Conversation
mz_version() is always defined in miniz.c, but its prototype in miniz.h sat inside the MINIZ_NO_ZLIB_APIS guard, so builds with that option got -Wmissing-prototypes warnings and no public declaration. Move the prototype above the guard. Fixes richgel999#290
Contributor
Author
|
Gentle ping — just checking if this has had a chance to be reviewed. This is a one-line header fix moving the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #290.
mz_version()is always defined in miniz.c, but its prototype in miniz.h was inside theMINIZ_NO_ZLIB_APISguard. With that option,-Wmissing-prototypeswarns and there's no public declaration. This moves the prototype above the guard.Checked with gcc
-std=c99 -Wall -Wextra -Wmissing-prototypes, with and withoutMINIZ_NO_ZLIB_APIS: the mz_version warning is gone, nothing else changes