Repository navigation
Do not panic when tan of a decimal number overflows - #1203
Merged
Merged
Conversation
Collaborator
|
There are merge conflicts. Can you fix? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the
decimalfeature,tanon a decimal number panics when the result overflows:decimal_functions::tancallsrust_decimal'sMathematicalOps::tan, which panics wheneverchecked_tanreturnsNone. That happens at π/2 (and 3π/2), where the reciprocal it takes divides by zero. The panic comes from inside a native function, so no engine limit stops it, and a script can take down the host with one call.sqrt,exp,lnandlog10in the same module already use the checked forms and raiseErrorArithmetic;tannow does the same.sinandcoswere checked too: theirchecked_forms cannot returnNonefor anyDecimal, so they are left alone.Added
test_math_decimal_tantotests/math.rs. Without the fix it panics; with it, it passes.cargo test --testspasses with default features and with thedecimal,no_float,decimal,decimal,unchecked,only_i32,decimalanddecimal,serde,metadata,internals,debugging,grainrows of the CI matrix;cargo fmt --checkand the CI clippy invocation are clean. CHANGELOG line under 1.27.1's bug fixes.