Skip to content

Remove match cases left unused by the .cmt cleanup - #8800

Merged
cknitt merged 1 commit into
masterfrom
fix-analysis-redundant-cases
Oct 12, 2026
Merged

cknitt merged 1 commit into
masterfrom
fix-analysis-redundant-cases

Conversation

@cknitt

@cknitt cknitt commented Oct 11, 2026

Copy link
Copy Markdown
Member

Follow-up to #8793. Removing the Packed constructor from the .cmt format left two catch-all match cases in the editor analysis unreachable, since Packed was the only constructor they matched:

  • analysis/src/process_cmt.ml
  • analysis/src/process_extra.ml

Since #8793 merged, these trigger an unused-match-case warning (warning 11) in every build. This PR removes both cases. Behavior is unchanged.

🤖 Generated with Claude Code

They only matched Packed, which #8793 removed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Christoph Knittel <ck@cca.io>
@codecov

codecov Bot commented Oct 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.58%. Comparing base (2adc866) to head (55d8bd6).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8800      +/-   ##
==========================================
- Coverage   80.59%   80.58%   -0.01%     
==========================================
  Files         453      447       -6     
  Lines       62016    61681     -335     
==========================================
- Hits        49979    49704     -275     
+ Misses      12037    11977      -60     
Files with missing lines Coverage Δ
analysis/src/process_cmt.ml 84.09% <ø> (+0.27%) ⬆️
analysis/src/process_extra.ml 87.04% <ø> (+0.35%) ⬆️

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pkg-pr-new

pkg-pr-new Bot commented Oct 11, 2026

Copy link
Copy Markdown

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript@8800

@rescript/belt

npm i https://pkg.pr.new/@rescript/belt@8800

@rescript/darwin-arm64

npm i https://pkg.pr.new/@rescript/darwin-arm64@8800

@rescript/darwin-x64

npm i https://pkg.pr.new/@rescript/darwin-x64@8800

@rescript/linux-arm64

npm i https://pkg.pr.new/@rescript/linux-arm64@8800

@rescript/linux-x64

npm i https://pkg.pr.new/@rescript/linux-x64@8800

@rescript/runtime

npm i https://pkg.pr.new/@rescript/runtime@8800

@rescript/win32-x64

npm i https://pkg.pr.new/@rescript/win32-x64@8800

commit: 55d8bd6

@cknitt

cknitt commented Oct 11, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-11T19:52:43.451861Z 55d8bd6 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 55d8bd6e06

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread analysis/src/process_cmt.ml
@github-actions

Copy link
Copy Markdown

@cknitt
cknitt requested a review from cristianoc October 11, 2026 20:00
@cknitt
cknitt merged commit b051e32 into master Oct 12, 2026
24 checks passed
@cknitt
cknitt deleted the fix-analysis-redundant-cases branch October 12, 2026 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants