Repository navigation
Remove match cases left unused by the .cmt cleanup - #8800
Conversation
They only matched Packed, which #8793 removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Christoph Knittel <ck@cca.io>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8800 +/- ##
==========================================
- Coverage 80.59% 80.58% -0.01%
==========================================
Files 453 447 -6
Lines 62016 61681 -335
==========================================
- Hits 49979 49704 -275
+ Misses 12037 11977 -60
🚀 New features to boost your workflow:
|
rescript
@rescript/belt
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 55d8bd6e06
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Developer playground preview: https://rescript-lang.github.io/rescript/dev-playground/?version=pr-8800 |
Follow-up to #8793. Removing the
Packedconstructor from the.cmtformat left two catch-all match cases in the editor analysis unreachable, sincePackedwas the only constructor they matched:analysis/src/process_cmt.mlanalysis/src/process_extra.mlSince #8793 merged, these trigger an unused-match-case warning (warning 11) in every build. This PR removes both cases. Behavior is unchanged.
🤖 Generated with Claude Code