Repository navigation
Measure text and inputs in Fantom with Skia (#59482) - #59482
Merged
Merged
Conversation
|
@rubennorte has exported this pull request. If you are a Meta employee, you can view the originating Diff in D126888503. |
|
Warning JavaScript API change detected This PR commits an update to
This change was flagged as: |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 26, 2026
Summary: Pull Request resolved: react#59482 Use Skia for intrinsic text layout so Fantom tests exercise real wrapping and font scaling. Keep measurement enabled by default and share layout and a consistent CPU configuration with screenshot painting to avoid host-dependent results. Pinned font development dependencies make internal and open-source rendering self-contained and reproducible. Changelog: [Internal] Add intrinsic text and input measurement to Fantom with Skia. Differential Revision: D126888503
rubennorte
force-pushed
the
export-D126888503
branch
from
October 26, 2026 15:02
65e3ce7 to
74aac32
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 26, 2026
Summary: Pull Request resolved: react#59482 Use Skia for intrinsic text layout so Fantom tests exercise real wrapping and font scaling. Keep measurement enabled by default and share layout and a consistent CPU configuration with screenshot painting to avoid host-dependent results. Pinned font development dependencies make internal and open-source rendering self-contained and reproducible. Changelog: [Internal] Add intrinsic text and input measurement to Fantom with Skia. Differential Revision: D126888503
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 26, 2026
Summary: Pull Request resolved: react#59482 Use Skia for intrinsic text layout so Fantom tests exercise real wrapping and font scaling. Keep measurement enabled by default and share layout and a consistent CPU configuration with screenshot painting to avoid host-dependent results. Pinned font development dependencies make internal and open-source rendering self-contained and reproducible. Changelog: [Internal] Add intrinsic text and input measurement to Fantom with Skia. Differential Revision: D126888503
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 26, 2026
Summary: Pull Request resolved: react#59482 Use Skia for intrinsic text layout so Fantom tests exercise real wrapping and font scaling. Keep measurement enabled by default and share layout and a consistent CPU configuration with screenshot painting to avoid host-dependent results. Pinned font development dependencies make internal and open-source rendering self-contained and reproducible. Changelog: [Internal] Add intrinsic text and input measurement to Fantom with Skia. Differential Revision: D126888503
rubennorte
force-pushed
the
export-D126888503
branch
from
October 26, 2026 16:07
74aac32 to
2367fbc
Compare
javache
pushed a commit
to javache/react-native
that referenced
this pull request
Oct 26, 2026
Summary: Pull Request resolved: react#59482 Use Skia for intrinsic text layout so Fantom tests exercise real wrapping and font scaling. Keep measurement enabled by default and share layout and a consistent CPU configuration with screenshot painting to avoid host-dependent results. Pinned font development dependencies make internal and open-source rendering self-contained and reproducible. Changelog: [Internal] Add intrinsic text and input measurement to Fantom with Skia. Differential Revision: D126888503
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 26, 2026
Summary: Pull Request resolved: react#59482 Use Skia for intrinsic text layout so Fantom tests exercise real wrapping and font scaling. Keep measurement enabled by default and share layout and a consistent CPU configuration with screenshot painting to avoid host-dependent results. Pinned font development dependencies make internal and open-source rendering self-contained and reproducible. Changelog: [Internal] Add intrinsic text and input measurement to Fantom with Skia. Differential Revision: D126888503
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 26, 2026
Summary: Pull Request resolved: react#59482 Use Skia for intrinsic text layout so Fantom tests exercise real wrapping and font scaling. Keep measurement enabled by default and share layout and a consistent CPU configuration with screenshot painting to avoid host-dependent results. Pinned font development dependencies make internal and open-source rendering self-contained and reproducible. Changelog: [Internal] Add intrinsic text and input measurement to Fantom with Skia. Differential Revision: D126888503
rubennorte
force-pushed
the
export-D126888503
branch
from
October 26, 2026 17:03
2367fbc to
1a9d9bd
Compare
javache
pushed a commit
to javache/react-native
that referenced
this pull request
Oct 26, 2026
Summary: Pull Request resolved: react#59482 Use Skia for intrinsic text layout so Fantom tests exercise real wrapping and font scaling. Keep measurement enabled by default and share layout and a consistent CPU configuration with screenshot painting to avoid host-dependent results. Pinned font development dependencies make internal and open-source rendering self-contained and reproducible. Changelog: [Internal] Add intrinsic text and input measurement to Fantom with Skia. Differential Revision: D126888503
javache
pushed a commit
to javache/react-native
that referenced
this pull request
Oct 26, 2026
Summary: Pull Request resolved: react#59482 Use Skia for intrinsic text layout so Fantom tests exercise real wrapping and font scaling. Keep measurement enabled by default and share layout and a consistent CPU configuration with screenshot painting to avoid host-dependent results. Pinned font development dependencies make internal and open-source rendering self-contained and reproducible. Changelog: [Internal] Add intrinsic text and input measurement to Fantom with Skia. Differential Revision: D126888503
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 26, 2026
Summary: Pull Request resolved: react#59482 Use Skia for intrinsic text layout so Fantom tests exercise real wrapping and font scaling. Keep measurement enabled by default and share layout and a consistent CPU configuration with screenshot painting to avoid host-dependent results. Pinned font development dependencies make internal and open-source rendering self-contained and reproducible. Changelog: [Internal] Add intrinsic text and input measurement to Fantom with Skia. Differential Revision: D126888503
javache
pushed a commit
to javache/react-native
that referenced
this pull request
Oct 26, 2026
Summary: Pull Request resolved: react#59482 Use Skia for intrinsic text layout so Fantom tests exercise real wrapping and font scaling. Keep measurement enabled by default and share layout and a consistent CPU configuration with screenshot painting to avoid host-dependent results. Pinned font development dependencies make internal and open-source rendering self-contained and reproducible. Changelog: [Internal] Add intrinsic text and input measurement to Fantom with Skia. Differential Revision: D126888503
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 27, 2026
Summary: Pull Request resolved: react#59482 Use Skia for intrinsic text layout so Fantom tests exercise real wrapping and font scaling. Keep measurement enabled by default and share layout and a consistent CPU configuration with screenshot painting to avoid host-dependent results. Pinned font development dependencies make internal and open-source rendering self-contained and reproducible. Changelog: [Internal] Add intrinsic text and input measurement to Fantom with Skia. Differential Revision: D126888503
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 27, 2026
Summary: Pull Request resolved: react#59482 Use Skia for intrinsic text layout so Fantom tests exercise real wrapping and font scaling. Keep measurement enabled by default and share layout and a consistent CPU configuration with screenshot painting to avoid host-dependent results. Pinned font development dependencies make internal and open-source rendering self-contained and reproducible. Changelog: [Internal] Add intrinsic text and input measurement to Fantom with Skia. Differential Revision: D126888503
rubennorte
force-pushed
the
export-D126888503
branch
from
October 27, 2026 12:19
1a9d9bd to
e82113b
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 27, 2026
Summary: Pull Request resolved: react#59482 Use Skia for intrinsic text layout so Fantom tests exercise real wrapping and font scaling. Keep measurement enabled by default and share layout and a consistent CPU configuration with screenshot painting to avoid host-dependent results. Pinned font development dependencies make internal and open-source rendering self-contained and reproducible. Changelog: [Internal] Add intrinsic text and input measurement to Fantom with Skia. Differential Revision: D126888503
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 27, 2026
Summary: Pull Request resolved: react#59482 Use Skia for intrinsic text layout so Fantom tests exercise real wrapping and font scaling. Keep measurement enabled by default and share layout and a consistent CPU configuration with screenshot painting to avoid host-dependent results. Pinned font development dependencies make internal and open-source rendering self-contained and reproducible. Changelog: [Internal] Add intrinsic text and input measurement to Fantom with Skia. Differential Revision: D126888503
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 27, 2026
Summary: Pull Request resolved: react#59482 Use Skia for intrinsic text layout so Fantom tests exercise real wrapping and font scaling. Keep measurement enabled by default and share layout and a consistent CPU configuration with screenshot painting to avoid host-dependent results. Pinned font development dependencies make internal and open-source rendering self-contained and reproducible. Changelog: [Internal] Add intrinsic text and input measurement to Fantom with Skia. Differential Revision: D126888503
rubennorte
force-pushed
the
export-D126888503
branch
from
October 27, 2026 13:34
e82113b to
da816db
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 27, 2026
Summary: Pull Request resolved: react#59482 Use Skia for intrinsic text layout so Fantom tests exercise real wrapping and font scaling. Keep measurement enabled by default and share layout and a consistent CPU configuration with screenshot painting to avoid host-dependent results. Pinned font development dependencies make internal and open-source rendering self-contained and reproducible. Changelog: [Internal] Add intrinsic text and input measurement to Fantom with Skia. Differential Revision: D126888503
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 27, 2026
Summary: Pull Request resolved: react#59482 Use Skia for intrinsic text layout so Fantom tests exercise real wrapping and font scaling. Keep measurement enabled by default and share layout and a consistent CPU configuration with screenshot painting to avoid host-dependent results. Pinned font development dependencies make internal and open-source rendering self-contained and reproducible. Changelog: [Internal] Add intrinsic text and input measurement to Fantom with Skia. Differential Revision: D126888503
rubennorte
force-pushed
the
export-D126888503
branch
from
November 9, 2026 13:40
5df21f1 to
fe2a93c
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Nov 9, 2026
Summary: Pull Request resolved: react#59482 Use Skia for intrinsic text layout so Fantom tests exercise real wrapping and font scaling. Keep measurement enabled by default and share layout and a consistent CPU configuration with screenshot painting to avoid host-dependent results. Pinned font development dependencies make internal and open-source rendering self-contained and reproducible. Changelog: [Internal] Add intrinsic text and input measurement to Fantom with Skia. Reviewed By: andrewdacenko Differential Revision: D126888503
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Nov 9, 2026
Summary: Pull Request resolved: react#59482 Use Skia for intrinsic text layout so Fantom tests exercise real wrapping and font scaling. Keep measurement enabled by default and share layout and a consistent CPU configuration with screenshot painting to avoid host-dependent results. Pinned font development dependencies make internal and open-source rendering self-contained and reproducible. Changelog: [Internal] Add intrinsic text and input measurement to Fantom with Skia. Reviewed By: andrewdacenko Differential Revision: D126888503
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Nov 9, 2026
Summary: Pull Request resolved: react#59482 Use Skia for intrinsic text layout so Fantom tests exercise real wrapping and font scaling. Keep measurement enabled by default and share layout and a consistent CPU configuration with screenshot painting to avoid host-dependent results. Pinned font development dependencies make internal and open-source rendering self-contained and reproducible. Changelog: [Internal] Add intrinsic text and input measurement to Fantom with Skia. Reviewed By: andrewdacenko Differential Revision: D126888503
rubennorte
force-pushed
the
export-D126888503
branch
from
November 9, 2026 13:46
fe2a93c to
260d838
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Nov 9, 2026
Summary: Pull Request resolved: react#59482 Use Skia for intrinsic text layout so Fantom tests exercise real wrapping and font scaling. Keep measurement enabled by default and share layout and a consistent CPU configuration with screenshot painting to avoid host-dependent results. Pinned font development dependencies make internal and open-source rendering self-contained and reproducible. Changelog: [Internal] Add intrinsic text and input measurement to Fantom with Skia. Reviewed By: andrewdacenko Differential Revision: D126888503
rubennorte
force-pushed
the
export-D126888503
branch
from
November 9, 2026 17:05
260d838 to
2e01d9c
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Nov 9, 2026
Summary: Pull Request resolved: react#59482 Use Skia for intrinsic text layout so Fantom tests exercise real wrapping and font scaling. Keep measurement enabled by default and share layout and a consistent CPU configuration with screenshot painting to avoid host-dependent results. Pinned font development dependencies make internal and open-source rendering self-contained and reproducible. Changelog: [Internal] Add intrinsic text and input measurement to Fantom with Skia. Reviewed By: andrewdacenko Differential Revision: D126888503
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Nov 9, 2026
Summary: Pull Request resolved: react#59482 Use Skia for intrinsic text layout so Fantom tests exercise real wrapping and font scaling. Keep measurement enabled by default and share layout and a consistent CPU configuration with screenshot painting to avoid host-dependent results. Pinned font development dependencies make internal and open-source rendering self-contained and reproducible. Changelog: [Internal] Add intrinsic text and input measurement to Fantom with Skia. Reviewed By: andrewdacenko Differential Revision: D126888503
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Nov 9, 2026
Summary: Pull Request resolved: react#59482 Use Skia for intrinsic text layout so Fantom tests exercise real wrapping and font scaling. Keep measurement enabled by default and share layout and a consistent CPU configuration with screenshot painting to avoid host-dependent results. Pinned font development dependencies make internal and open-source rendering self-contained and reproducible. Changelog: [Internal] Add intrinsic text and input measurement to Fantom with Skia. Reviewed By: andrewdacenko Differential Revision: D126888503
rubennorte
force-pushed
the
export-D126888503
branch
from
November 9, 2026 17:10
2e01d9c to
69cbfbb
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Nov 9, 2026
Summary: Pull Request resolved: react#59482 Use Skia for intrinsic text layout so Fantom tests exercise real wrapping and font scaling. Keep measurement enabled by default and share layout and a consistent CPU configuration with screenshot painting to avoid host-dependent results. Pinned font development dependencies make internal and open-source rendering self-contained and reproducible. Changelog: [Internal] Add intrinsic text and input measurement to Fantom with Skia. Reviewed By: andrewdacenko Differential Revision: D126888503
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Nov 9, 2026
Summary: Pull Request resolved: react#59482 Use Skia for intrinsic text layout so Fantom tests exercise real wrapping and font scaling. Keep measurement enabled by default and share layout and a consistent CPU configuration with screenshot painting to avoid host-dependent results. Pinned font development dependencies make internal and open-source rendering self-contained and reproducible. Changelog: [Internal] Add intrinsic text and input measurement to Fantom with Skia. Reviewed By: andrewdacenko Differential Revision: D126888503
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Nov 10, 2026
Summary: Pull Request resolved: react#59482 Use Skia for intrinsic text layout so Fantom tests exercise real wrapping and font scaling. Keep measurement enabled by default and share layout and a consistent CPU configuration with screenshot painting to avoid host-dependent results. Pinned font development dependencies make internal and open-source rendering self-contained and reproducible. Changelog: [Internal] Add intrinsic text and input measurement to Fantom with Skia. Reviewed By: andrewdacenko Differential Revision: D126888503
rubennorte
force-pushed
the
export-D126888503
branch
from
November 10, 2026 11:42
69cbfbb to
d21b6f7
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Nov 10, 2026
Summary: Pull Request resolved: react#59482 Use Skia for intrinsic text layout so Fantom tests exercise real wrapping and font scaling. Keep measurement enabled by default and share layout and a consistent CPU configuration with screenshot painting to avoid host-dependent results. Pinned font development dependencies make internal and open-source rendering self-contained and reproducible. Changelog: [Internal] Add intrinsic text and input measurement to Fantom with Skia. Reviewed By: andrewdacenko Differential Revision: D126888503
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Nov 10, 2026
Summary: Pull Request resolved: react#59482 Use Skia for intrinsic text layout so Fantom tests exercise real wrapping and font scaling. Keep measurement enabled by default and share layout and a consistent CPU configuration with screenshot painting to avoid host-dependent results. Pinned font development dependencies make internal and open-source rendering self-contained and reproducible. Changelog: [Internal] Add intrinsic text and input measurement to Fantom with Skia. Reviewed By: andrewdacenko Differential Revision: D126888503
cipolleschi
approved these changes
Nov 10, 2026
Summary: Pull Request resolved: react#59482 Use Skia for intrinsic text layout so Fantom tests exercise real wrapping and font scaling. Keep measurement enabled by default and share layout and a consistent CPU configuration with screenshot painting to avoid host-dependent results. Pinned font development dependencies make internal and open-source rendering self-contained and reproducible. Changelog: [Internal] Add intrinsic text and input measurement to Fantom with Skia. Reviewed By: andrewdacenko Differential Revision: D126888503
rubennorte
force-pushed
the
export-D126888503
branch
from
November 10, 2026 17:03
d21b6f7 to
82970f4
Compare
Collaborator
|
This pull request was successfully merged by @rubennorte in cea863e When will my fix make it into a release? | How to file a pick request? |
This was referenced Nov 11, 2026
usama-liaqat
pushed a commit
to usama-liaqat/react-native
that referenced
this pull request
Nov 14, 2026
Summary: Use Skia for intrinsic text layout so Fantom tests exercise real wrapping and font scaling. Keep measurement enabled by default and share layout and a consistent CPU configuration with screenshot painting to avoid host-dependent results. Pinned font development dependencies make internal and open-source rendering self-contained and reproducible. Changelog: [Internal] Add intrinsic text and input measurement to Fantom with Skia. Reviewed By: andrewdacenko Differential Revision: D126888503 Pull Request resolved: react#59482
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Use Skia for intrinsic text layout so Fantom tests exercise real wrapping and font scaling. Keep measurement enabled by default and share layout and a consistent CPU configuration with screenshot painting to avoid host-dependent results.
Pinned font development dependencies make internal and open-source rendering self-contained and reproducible.
Changelog: [Internal] Add intrinsic text and input measurement to Fantom with Skia.
Reviewed By: andrewdacenko
Differential Revision: D126888503