Repository navigation
Build OpenSSL 1.0 without parallel make - #2651
Merged
Merged
Conversation
Two `ar` runs into libcrypto.a can overlap under make -j and drop each other's objects, which breaks every Ruby 2.3 and older build on the ubuntu-26.04 runners. The `-j 1` that used to prevent this stopped taking effect when 3a4d3fb moved MAKE_OPTS after the package options, and 6663720 removed it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
eregon
approved these changes
Nov 1, 2026
Member
There was a problem hiding this comment.
Looks good to me, and it addresses my old comment here, thanks
Member
Author
|
Thanks for the review. With this fix, ruby-builder now has ruby-2.3.8 for ubuntu-26.04 and ubuntu-26.04-arm. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into this while making ruby/ruby-builder build Ruby 2.3 on
ubuntu-26.04. The bundled OpenSSL 1.0.2u fails to link there, because itscrypto/Makefilelets twoarruns writelibcrypto.aat once under parallel make, and one drops the other's objects.ruby-build used to pass
-j 1to OpenSSL. It stopped taking effect when 3a4d3fb movedMAKE_OPTSafter it, and #2270 removed it since builds kept passing without it. This puts it back for OpenSSL 1.0 only.Generated with Claude Code