Repository navigation
Fix broken tests due to timezones. - #779
Merged
Merged
Conversation
This fixes two tests that were generating output that was dependent on the timezone. In both cases, now was formatted to include the timezone name which was failing on my machine.
There was a problem hiding this comment.
🟢 Approval recommended
The timezone-dependent tests are consistently normalized to UTC, with no unresolved review issues.
No open issues 🎉
What changed in this PR
This pull request fixes timezone-dependent test output by generating timestamps in UTC for project and cluster member tests.
Changes:
- Use
time.Now().UTC()in the project member test. - Use
time.Now().UTC()in the cluster member test. - Ensure formatted expected output is consistent across local timezones.
| File | Description |
|---|---|
cmd/project_test.go |
Uses a UTC timestamp for deterministic project member output assertions. |
cmd/cluster_test.go |
Uses a UTC timestamp for deterministic cluster member output assertions. |
Review effort: Lite
andreas-kupries
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reviewing #778 I trigged a timezone related bug
This fixes two tests that were generating output that was dependent on the timezone.
In both cases, now was formatted to include the timezone name which was failing on my machine.