Repository navigation
[Auth restructure 2] Some fixes for rspotify-model and rspotify-macros - #214
Merged
Merged
Conversation
marioortizmanero
changed the base branch from
separate-crates
to
auth-rewrite-part1
June 19, 2021 10:14
rspotify-model and rspotify-macros
marioortizmanero
force-pushed
the
auth-rewrite-part2
branch
from
June 19, 2021 10:30
b34be92 to
8397c9b
Compare
Owner
|
It seems, some CI checks failed, it will be automatically fixed after merged part 3? |
Collaborator
Author
|
Yes. The CI will only work after merging the third PR |
ramsayleung
reviewed
Jun 29, 2021
| @@ -13,4 +16,3 @@ edition = "2018" | |||
| [dev-dependencies] | |||
| serde_json = "1.0.57" | |||
| chrono = { version = "0.4.13", features = ["serde", "rustc-serialize"] } | |||
Owner
There was a problem hiding this comment.
The macro crate should relay on no dependency, since it has nothing to do with external dependencies.
Collaborator
Author
There was a problem hiding this comment.
These are dev dependencies, they're only needed for tests. You're right that we don't need chrono, though. I've removed it.
Owner
|
Beside this nitpick I mention, everything looks good to me. |
ramsayleung
approved these changes
Jun 29, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 2 of the #207 split-up.
This:
rspotify-modelrspotify-macrosThese things are needed later to test the crate without cyclical dependencies, and mostly clean up a few things. Both of the crates I modified should compile without problems, but not the main one.