Repository navigation
fix: import caldav.testing.registry on its own - #828
Merged
Merged
Conversation
Importing caldav.testing.registry before anything else in the package failed: registry imports base, and base imported registry back to register the external server class. The tests/test_servers package always imported base first, which hid the cycle. The external class is now registered in registry itself. Prompt: (while working with the calendaring library) Do the needful ensuring all tests are run towards all servers ... Assisted-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
The import test imported the caldav package beside the module's from-import of caldav.testing.base, which code scanning flags. The checkout root now comes from base.__file__. #828 Prompt: Fix the import for 828. [the code-scanning thread on #828: caldav imported with both import and from-import] Assisted-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit message:
Follow-up to #824.
🤖 Generated with Claude Code