Repository navigation
fix: make sync clients work without async http library - #827
Merged
tobixen merged 2 commits intoOct 25, 2026
Merged
Conversation
is_async_client imports AsyncDAVClient, which raises ImportError if no async HTTP library is installed. Clients now have an is_async class attribute instead.
is_async_client now reads the attribute with getattr, so duck-typed clients that do not derive from BaseDAVClient count as sync, as the old isinstance check did. Add a regression test that blocks every async HTTP library in a subprocess and checks the sync client still works, and a changelog fragment for the PR. Prompt: Let Opus do a code review of PR#827. LGTM, and if Opus agree, merge it using the /merge-prs skill. If Opus says something should be changed, then add another commit to the PR. Assisted-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Member
|
LGTM. I had Claude Opus 5.5 do a code review, and it always finds things to complain about: a duck typed client object without this attribute would cause an |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
is_async_clientimported AsyncDAVClient, which raisedImportError if no async HTTP library was installed.
Clients now have an
is_asyncclass attribute instead,so the check does not require an async library to be installed.