Repository navigation
fix: set ResponseError.status for failed replies - #819
Merged
Merged
Conversation
tobixen
force-pushed
the
fix/response-error-status
branch
from
October 24, 2026 00:02
7e855c5 to
e76edcb
Compare
DAVError gained a status attribute in 3.6.0, but a failing status inside a multistatus (a 507 <propstat> or <response> status in a PROPFIND reply, say) raised a ResponseError with status None, so the code could only be read from the message text. That check now passes the code, or None for a status line it cannot parse. For consistency the parse_* methods' non-2xx raises go through error_from_response(), keeping body and preconditions too, and the foreign-href sync 507 passes its code. Prompt: A 507 from propfind comes back as a ResponseError with status set to None Assisted-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
tobixen
force-pushed
the
fix/response-error-status
branch
from
October 24, 2026 08:12
e76edcb to
824e26e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit message:
🤖 Generated with Claude Code