Repository navigation
Conversation
`Indexes.__init__` and `Index.create_variables` copied mappings with
`dict(**mapping)`, which only accepts string keys, so an indexed coordinate
named e.g. `10` or `("a", "b")` raised `TypeError: keywords must be strings`.
Also generalize the HTML repr tests for non-string names into one test
covering dimensions, coordinates, indexes, variables and attributes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
headtr1ck
force-pushed
the
nonstr-index-names
branch
from
November 15, 2026 20:24
c814a2c to
de4ddab
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Indexed coordinates can now have non-string names, like other variables:
Indexes.__init__andIndex.create_variables(also inNDPointIndex) copied mappings withdict(**mapping), which only accepts string keys, so e.g.DataArray(..., dims=(10,), coords={10: [...]})raisedTypeError: keywords must be strings. They now usedict(mapping). The**form dates from Explicit indexes #5692 and Expose "Coordinates" as part of Xarray's public API #7368 and was only meant as a copy.Variable,DataArray,DatasetandDataTree.Checklist
whats-new.rstAI Disclosure
Tools: Claude Code
🤖 Generated with Claude Code