Repository navigation
Conversation
Expose the master device of a network interface (a VRF, bridge or bond), which sysfs provides as the /sys/class/net/<iface>/master symlink. Closes prometheus#405 Signed-off-by: Srinivas Chippagiri <cvas22@gmail.com>
Author
|
@SuperQ @discordianfish could one of you take a look when you have a minute? thx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #405
The issue asks for the VRF association of an interface to be available from
NetClassIface. sysfs exposes the master device of an interface (a VRF, but also a bridge or bond) as the/sys/class/net/<iface>/mastersymlink, e.g.master -> ../VrfKamel. That avoids needing netlink, which was the alternative mentioned on the issue.This adds a
Masterfield holding the name of the master device (the last element of the symlink target). It stays empty if the interface has no master or the link cannot be read for an ignorable reason (missing, permission, not a symlink), the same way other attributes are handled.Tests: added a
master -> ../vrf0symlink to theeth0fixture intestdata/fixtures.ttarand the expectation inTestNetClass. I am on Windows, so I could not unpack the fixtures or run the sysfs tests locally (the package is Linux only and the fixtures need symlinks); I checked it withGOOS=linux go vet ./sysfs/and the fixture entry follows the existingSymlinkToformat. CI should run the real test.