Repository navigation
Conversation
…escriptions Signed-off-by: v-zhuravlev <v-zhuravlev@users.noreply.github.com>
The NodeNetworkReceiveErrs and NodeNetworkTransmitErrs expressions are an error/packet ratio, so render the value with humanizePercentage. Co-authored-by: Arthur Silva Sens <arthursens2005@gmail.com> Signed-off-by: Lucas Barros <lucasbarros.kam@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #3752, carries over @v-zhuravlev's work (their commit is kept, with them as author).
NodeNetworkReceiveErrsandNodeNetworkTransmitErrsfire onrate(errs) / rate(packets) > 0.01, so$valueis a ratio, but the description printed it as a count withprintf "%.0f". A firing alert at 3% errors read "has encountered 0 receive errors in the last two minutes".#3752 changed the format to
%.2f; this applies @ArthurSens's suggestion from the review there and renders it withhumanizePercentage:Tested by rendering the mixin and running a rule unit test:
test.yamlfeeds 3 receive errors and 2 transmit errors per 100 packets per minute for eth0 and expects both alerts at 75m with the descriptions above (3% and 2%).jsonnetfmtreports no diff.AI disclosure: written with the help of Claude Code, reviewed and tested by me.