Skip to content

Identify constants for movement status and fast NPC movement, and label movement.asm - #175

Merged
dannye merged 1 commit into
pret:masterfrom
Rangi42:movement
Oct 28, 2026
Merged

dannye merged 1 commit into
pret:masterfrom
Rangi42:movement

Conversation

@Rangi42

@Rangi42 Rangi42 commented Oct 26, 2026

Copy link
Copy Markdown
Member
Unnamed pokeyellow symbols: 119 (99.84% complete)
engine/pikachu/pikachu_follow.asm: 57
engine/overworld/sprite_collisions.asm: 3
engine/pikachu/pikachu_movement.asm: 2

This copies @thoth-33's changes from #134 that haven't become outdated, applying my own review suggestions to them (so the movement status value constants are grouped with their significant bit 7). Thank you for identifying these movement constants and completely labeling movement.asm!

@dannye dannye left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you both!

@dannye
dannye merged commit bf03639 into pret:master Oct 28, 2026
2 checks passed
github-actions Bot pushed a commit that referenced this pull request Oct 28, 2026
…el movement.asm (#175)

Co-authored-by: thoth-33 <146050985+thoth-33@users.noreply.github.com>
@Rangi42
Rangi42 deleted the movement branch October 28, 2026 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants