Repository navigation
Add constants for trainer macro struct data - #598
Merged
Merged
Conversation
Easier understanding of dealing with this data struct. Also can track its size with TRAINER_STRUCT_SIZE
Rangi42
requested changes
Aug 8, 2026
Contributor
Author
|
Essentially when you lose it doesn't go to print any loss text ever, although it technically has an extra pointer stored. It could have been any sort of text, but based on the order could have been loss text. |
Rangi42
requested changes
Aug 8, 2026
Member
|
(GitHub is having issues with accepting the changes I commented...) |
Rangi42
reviewed
Aug 8, 2026
Rangi42
requested changes
Aug 8, 2026
Rangi42
approved these changes
Aug 8, 2026
Rangi42
left a comment
Member
There was a problem hiding this comment.
Thanks! Sorry for all the commits, batch merge wasn't working.
github-actions Bot
pushed a commit
that referenced
this pull request
Aug 8, 2026
--------- Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Easier understanding of dealing with this data struct. Also can track its size with TRAINER_STRUCT_SIZE. I was tripped up when modifying it because a magic number was used to navigate to the next trainer in the struct in home/trainers.asm.