Repository navigation
Comment inactive warp in SilphCo1F - #591
Merged
Merged
Conversation
CreamElDudJafar
left a comment
Contributor
There was a problem hiding this comment.
I think there a few warps inactive or unused in silph. I think 11F has one and maybe 3rd or 7th floor too. Maybe comment them all inactive?
Rangi42
requested changes
Jun 28, 2026
Rangi42
left a comment
Member
There was a problem hiding this comment.
Yeah, if this isn't a one-off, please use this PR to comment the rest of the inactive events.
Rangi42
marked this pull request as draft
June 28, 2026 17:05
Contributor
Author
|
I commented the one on SilphCo11F. Nothing on SilphCo3F or SilphCo7F as far as I can see. Also commented one in CeladonCity, that's the only one I could think of on the top of my head. If you know more I'm happy to add them. |
Rangi42
reviewed
Aug 10, 2026
Rangi42
left a comment
Member
There was a problem hiding this comment.
Changed to "inaccessible" to match the comment in Gen 2's OlivineCity.asm.
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
Rangi42
marked this pull request as ready for review
August 10, 2026 15:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.