Repository navigation
Conversation
- README: the sample Go migration link said 00002_users_add_email.go, but it points to (and the sample shows) 00002_rename_root.go, and no file by the old name exists - README: Go migrations step 2 said to import github.com/pressly/goose; the module path is github.com/pressly/goose/v3, as used in the sample below it - doc/dialect-clickhouse.md: "databas engine" -> "database engine"
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Go Migrations section of the README links to a "sample Go migration 00002_users_add_email.go file", but the link points to
examples/go-migrations/00002_rename_root.go, the code sample below it is the rename_root migration, and no00002_users_add_email.goexists in the repo. Changed the link text to match the file.Step 2 of the same section said to import
github.com/pressly/goose; the module path isgithub.com/pressly/goose/v3(as ingo.modand the sample right below), so updated that too.Also fixes one typo in
doc/dialect-clickhouse.md: "databas engine" -> "database engine".Docs-only change, no behaviour change.