Skip to content

Fix attempt of auto browser sign in. Closes #887 - #900

Open
Adam-it wants to merge 2 commits into
pnp:devfrom
Adam-it:fix-sign-in-bug
Open

Adam-it wants to merge 2 commits into
pnp:devfrom
Adam-it:fix-sign-in-bug

Conversation

@Adam-it

@Adam-it Adam-it commented Oct 4, 2026 •

Copy link
Copy Markdown
Member

🎯 Aim

The aim is to try to fix the issue with auto sign in page open in browser on VS Code start.

✅ What was done

  • Updated CLI for M365 SPFx Toolkit to do not perform interactive sign in in m365 status command
  • Updated to run status check once on start
  • Updated status/signin error handling to show as sign out state

🧪 Test

Best way to test is to build the extension locally and install from local build, then sign in and wait 1-2 days with no usage of SPFx Toolkit and recheck the behavior after that.

🔗 Related issue

Closes: #887

@Adam-it
Adam-it changed the base branch from main to dev October 4, 2026 21:57
@Adam-it Adam-it changed the title Fix attempt of auto browser sign in Fix attempt of auto browser sign in. Closes #887 Oct 4, 2026
@Adam-it Adam-it linked an issue Oct 4, 2026 that may be closed by this pull request
@Adam-it
Adam-it marked this pull request as ready for review October 4, 2026 22:01
@Saurabh7019 Saurabh7019 self-assigned this Oct 5, 2026
Comment thread src/providers/AuthProvider.ts Resolved
@nicodecleyre

Copy link
Copy Markdown
Contributor

Hi @Adam-it 👋 We just released v4.23.0 and the dev branch was realigned with main (force push). Could you please rebase your branch on the latest dev? Thank you! 🙏

git fetch upstream
git rebase upstream/dev
git push --force-with-lease

@Adam-it
Adam-it marked this pull request as draft November 10, 2026 22:16
@Adam-it
Adam-it marked this pull request as ready for review November 11, 2026 23:23
@Adam-it

Adam-it commented Nov 11, 2026

Copy link
Copy Markdown
Member Author

@Saurabh7019 I am checking this now but it seems like good to go now. Ready for a recheck?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐞 Bug report: Auth token expiry breaks Account and Actions views

3 participants