Repository navigation
Allow bulk operations for all apps in an app catalog, Closes #442 - #689
Conversation
cb2b2f5 to
d45edba
Compare
d45edba to
7bda5bb
Compare
Adam-it
left a comment
There was a problem hiding this comment.
@nicodecleyre awesome work!
I played around with it a bit and checked most of the bulk options
What we forgot in this PR is updating the docs. Since docs are now part of our code we should update it together with the PR so when it gets shipped we wont miss to align the documenatation.
Also I would move the buld operations to a new SpgxAppCLIBulkAction.ts file to make for better maintability so we dont make the SpgxAppCLIAction to long
fba1b4d to
609cf4a
Compare
Adam-it
left a comment
There was a problem hiding this comment.
@nicodecleyre ready for another round?
I rechecked the PR and left a few comments we could recheck. Let me know if you need any help
2c84a0b to
fd39e59
Compare
|
We just had a new minor release. We should rebase this branch, as well, before we proceed |
33028e8 to
a988805
Compare
Adam-it
left a comment
There was a problem hiding this comment.
@nicodecleyre I added a few fixups but the PR is not ready yet.
I think during the refactor in the PR there was a logical error introduced in which in many places the url to site level app catalog is introduced instead of the url to the site
I am still investigating this but from what I tested most of the bulk operations won't work due to this error. Maybe you wanna check this case as well.
Also shouldn't those bulk operations be also visible on tenant level app catalog?
I think it should that is why in SpfxAppCLIBulActions.ts in lines 603-618 we handle the case in which the app catalog is null and then the user may specify the relative site URL to which the app should be installed/uninstalled 🤔
|
we also need to rebase this branch against latest dev since we just had a minor release |
|
We just did a minor release of SPFx Toolkit, agian. Please rebase this branch to align with latest dev before we proceed |
90ba561 to
4d8d770
Compare
|
@nicodecleyre we had another minor release and we need to rebase this one again. |
Ready |
Adam-it
left a comment
There was a problem hiding this comment.
@nicodecleyre unfortunately I still noticed a few issues with the PR a few of them quite important we need to address before we merge. Let's give this another go
7a1d3f1 to
7c547ef
Compare
|
hey we just had a new minor release which means we aligned out main branch with dev. Please perform a rebase so we may proceed with a PR. You Rock 🤩 |
d5f6fb7 to
de5e698
Compare
de5e698 to
6efe423
Compare
6efe423 to
0741bc6
Compare
0741bc6 to
4b22050
Compare
Adds bulk deploy/retract/remove/enable/disable/install/uninstall/upgrade commands for app catalog apps, and fixes getAppCatalogUrlFromNode to strip the /AppCatalog suffix and return undefined for the tenant catalog node.
🎯 Aim
This issue allows bulk operations for all apps in an app catalog
📷 Result
✅ What was done
🔗 Related issue
Closes: #442