Skip to content

Remove cljx - #92

Merged
loganlinn merged 3 commits into
plumatic:masterfrom
iku000888:feature/goodbye-cljx
Jun 30, 2018
Merged

loganlinn merged 3 commits into
plumatic:masterfrom
iku000888:feature/goodbye-cljx

Conversation

@iku000888

@iku000888 iku000888 commented Jun 28, 2018 •

Copy link
Copy Markdown
Collaborator

Why?

I would like to interactively develop om-tools as a local checkout in my project at work and cljx is problematic for this.

Solution?

Use reader conditionals by migrating to cljc

Consequences

  • Minimum clojure version 1.7
  • But as a Consequence of cljs version mentioned below, 1.8

cljs and om version

Same as the one I use at work. I think nobody has the bandwidth to support old versions.

TODO

  • drop tests for old om versions
  • drop cljx
  • check that it works in the project I work on
  • check that the examples are functional
  • make the tests pass, or
  • skpi the tests for now

@iku000888 iku000888 changed the title Remove cljx [WIP] Remove cljx Jun 28, 2018
@iku000888
iku000888 force-pushed the feature/goodbye-cljx branch 2 times, most recently from e0183f4 to b72a115 Compare June 28, 2018 17:04

@loganlinn loganlinn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ll have time to test & approve this tomorrow, but this is awesome. Thank you!

@loganlinn

loganlinn commented Jun 28, 2018 •

Copy link
Copy Markdown
Member

Oh it looks like the tests are failing. Let’s get those fixed up.

Edit: sorry I missed the WIP in title. Got excited! :D

@iku000888
iku000888 force-pushed the feature/goodbye-cljx branch 2 times, most recently from a77b393 to 01dc2ae Compare June 28, 2018 18:39
@iku000888

Copy link
Copy Markdown
Collaborator Author

@loganlinn

Sorry for the churn!
My effort budget ran out on trying to make the cljs tests pass.

In the interest of moving forward, I propose to stash the tests as I am guessing that the tests fail because they rely on react internals and react-addons, which also need to be upgraded along with om.

If you do have some bandwidth to check the cljs tests and have some tricks to move forward that would be best, but otherwise I will use the example apps and the project at work as a Q.A. platform in the meanwhile.

What do you think?

@iku000888
iku000888 force-pushed the feature/goodbye-cljx branch from 91862c6 to 98474dc Compare June 28, 2018 19:52
@iku000888
iku000888 force-pushed the feature/goodbye-cljx branch from 98474dc to 3410437 Compare June 28, 2018 20:04
@iku000888

Copy link
Copy Markdown
Collaborator Author

@loganlinn

So I fixed the tests sufficiently that I can run most of the tests in the browser. Commented out the tests that are problematic.

image

I am seeing that phantomjs is timing out on travis, so I am more confident that we should consider letting it go...

I think this is a happy middle ground as a merge point, so yeah let me know what you think...

@iku000888 iku000888 changed the title [WIP] Remove cljx Remove cljx Jun 28, 2018
@iku000888

Copy link
Copy Markdown
Collaborator Author

@loganlinn Would be awesome if I could ship this to so I can start work on catching up against latest om/react (and then fixing the tests), so if there is anything else I can do, just let me know 🙏

Thanks for your time 🙇‍♂️

@loganlinn loganlinn left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iku000888 Got this working on my machine no problem and everything looks great. Thank you!

I am seeing that phantomjs is timing out on travis, so I am more confident that we should consider letting it go..

Sounds good. Would be great to find a replacement, but I am happy to merge with disabled for time being

@loganlinn
loganlinn merged commit db2f464 into plumatic:master Jun 30, 2018
@iku000888
iku000888 deleted the feature/goodbye-cljx branch June 30, 2018 18:55
loganlinn added a commit that referenced this pull request Jun 30, 2018
In preparation to cut a release for #92.
@iku000888

Copy link
Copy Markdown
Collaborator Author

@loganlinn Thanks for the understanding! 🙏

Next goal for me is to do the catch up work with recent om/react 💪

@w01fe If you could push a release so I could put this into battle at work that would be awesome ;)
No rush tho.

@loganlinn

Copy link
Copy Markdown
Member

@iku000888 I've released 0.5.0 to clojars: https://clojars.org/prismatic/om-tools/versions/0.5.0

@iku000888

iku000888 commented Jul 4, 2018 via email

Copy link
Copy Markdown
Collaborator Author

@iku000888 iku000888 mentioned this pull request Jul 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants