Repository navigation
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the changed-line link-check workflow hardening.
No open issues 🎉
What changed in this PR
This PR hardens the changed-line link-check workflow by separating generated files from the PR checkout and preventing added Markdown text from being mistaken for diff file headers.
Changes:
- Recognizes file headers only outside diff hunks while preserving added-line link detection.
- Moves extracted content, input lists, and the Lychee report into a fresh runner temporary directory.
- Disables persisted checkout credentials and quotes workflow paths.
| File | Description |
|---|---|
.github/workflows/link-fail-fast.yaml |
Isolates generated inputs and reports in runner temporary storage and disables credential persistence. |
.github/scripts/extract-changed-markdown-lines.pl |
Tracks diff hunk state to distinguish file headers from added Markdown content. |
Review effort: Balanced
What is changed, added, or deleted? (Required)
The changed-lines link check can mistake added Markdown text for a diff file header and write generated files through symlinks in the PR checkout. Recognize file headers only outside diff hunks and write the extracted lines, input lists, and Lychee report to a fresh runner temporary directory. The checkout also stops persisting credentials because this job only needs local Git operations after checkout.
Verified locally with real Git diffs and Lychee v0.24.2. The regression fixture can overwrite a helper before the change, while the updated workflow preserves the helper and still finds external links and site-relative
hreflinks.Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit