You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Clarify the MariaDB-to-TiDB migration guide so it points readers to the version-specific MariaDB privilege requirements in dm-worker-intro instead of listing an incomplete subset inline.
Replace the MariaDB precheck workaround in the migration guide and DM compatibility catalog with the narrower replication_privilege, dump_privilege, and conn_number skips documented for DM v8.5.6, and remind readers to verify the corresponding privileges and connection limit manually.
Clarify that the linked TiDB Lightning and DM quick-start guides are for test or development environments, and point production users to the relevant production guidance.
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
The changes in this PR were primarily made by an AI agent on behalf of the PR author.
Do your changes match any of the following descriptions?
Delete files
Change aliases
Need modification after applied to another branch
Might cause conflicts after applied to another branch
Summary by CodeRabbit
Documentation
Updated MariaDB migration guidance with version-specific privilege requirements.
For DM v8.5.6, documented a targeted workaround for specified precheck failures: ignore only replication privilege, dump privilege, and connection-number checks, then manually verify the required privileges and connection limit.
Clarified that connection-number checks cover upstream dump and downstream load stages, not incremental replication.
Added separate guidance for test or trial environments and production migration planning.
It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.
No actionable comments were generated in the recent review.
Walkthrough
The MariaDB migration guide now links to environment-specific guidance and documents version-specific DM privileges and a conditional DM v8.5.6 precheck workaround. DM documentation clarifies which connections the conn_number check covers.
The guide links test or trial users to the Getting Started guide and production deployments to production migration guidance.
DM privileges and precheck workaround migrate-from-mariadb.md, dm/dm-compatibility-catalog.md, dm/dm-precheck.md
The guidance links to version-specific privilege requirements and documents the DM v8.5.6 workaround for replication_privilege, dump_privilege, and conn_number checks. It directs users to verify privileges and connection limits manually. The precheck table describes the upstream dump-stage and downstream load-stage connections checked by conn_number, excluding incremental-replication connections.
pingcap/docs#24361: Changes wording for the MariaDB dump-connection precheck that this update also documents.
Suggested reviewers:alastori
Merge Risk: Low · up to 0a834
The workaround could lead readers to overlook the downstream connection limit. The linked precheck documentation explains both limits, so the remaining risk is bounded.
Pre-merge checks: 5
Check name
Status
Explanation
Title check
The title clearly summarizes the main change: clarifying MariaDB migration prerequisites for DM.
Description check
The description covers the required change summary, affected TiDB versions, reference links, AI involvement, and applicable change checkboxes. The first-time contributor checklist is conditional and c…
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Description check
Explanation
The description covers the required change summary, affected TiDB versions, reference links, AI involvement, and applicable change checkboxes. The first-time contributor checklist is conditional and can be omitted when it does not apply.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Reviewing files that changed from the base of the PR and between b0beec4 and 0a834df.
Files selected for processing: 1
dm/dm-precheck.md
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 1 remain after this review.
Reviewing files that changed from the base of the PR and between 16b9550 and 38d42c9.
Files selected for processing: 2
dm/dm-compatibility-catalog.md
migrate-from-mariadb.md
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
Two active documentation inconsistencies remain: both new workarounds reference dm-precheck.md without documenting the conn_number check they instruct users to bypass.
Clarifies MariaDB-to-TiDB migration prerequisites and provides version-specific DM v8.5.6 precheck guidance while distinguishing test or development workflows from production deployment guidance.
Changes:
Links users to version-specific MariaDB privilege requirements.
Narrows the precheck workaround to replication_privilege, dump_privilege, and conn_number, with manual verification guidance.
Adds separate guidance for test or trial environments and production migration procedures.
File
Description
migrate-from-mariadb.md
Updates MariaDB migration prerequisites, DM precheck handling, and test-versus-production guidance.
dm/dm-compatibility-catalog.md
Documents the narrower DM v8.5.6 MariaDB precheck workaround and related privilege references.
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from lilin90. For more information see the Code Review Process. Please ensure that each of them provides their approval before proceeding.
The full list of commands accepted by this bot can be found here.
Details
Needs approval from an approver in each of these files:
Reviewing files that changed from the base of the PR and between 38d42c9 and b0beec4.
Files selected for processing: 3
dm/dm-compatibility-catalog.md
dm/dm-precheck.md
migrate-from-mariadb.md
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
area/dmcontributionThis PR is from a community contributor.needs-cherry-pick-release-8.5Should cherry pick this PR to release-8.5 branch.ONCALLRelates to documentation oncall.size/SDenotes a PR that changes 10-29 lines, ignoring generated files.translation/welcomeWaits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository.type/bugfixThis PR fixes a bug.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed, added, or deleted? (Required)
dm-worker-introinstead of listing an incomplete subset inline.replication_privilege,dump_privilege, andconn_numberskips documented for DM v8.5.6, and remind readers to verify the corresponding privileges and connection limit manually.Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit