You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
privilege-management: add AUDIT_ADMIN and RESTRICTED_AUDIT_ADMIN - #24666
Add the AUDIT_ADMIN and RESTRICTED_AUDIT_ADMIN dynamic privileges to the dynamic privilege list in privilege-management.md, and list the products where they are available: TiDB Enterprise, TiDB Cloud Dedicated, TiDB Cloud Premium, and TiDB Cloud Essential (database audit logging is in beta and available upon request). TiDB Cloud Starter does not support database audit logging.
Both privileges control database audit log management: audit-related system variables, manual audit log rotation, and audit log filters/rules. AUDIT_ADMIN is required when SEM is disabled, and RESTRICTED_AUDIT_ADMIN is required when SEM is enabled.
Which TiDB version(s) do your changes apply to? (Required)
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from lilin90. For more information see the Code Review Process. Please ensure that each of them provides their approval before proceeding.
The full list of commands accepted by this bot can be found here.
Details
Needs approval from an approver in each of these files:
The Dynamic privileges list documents AUDIT_ADMIN for managing database audit logs when SEM is disabled and RESTRICTED_AUDIT_ADMIN when SEM is enabled. It also lists supported products and access requirements.
Changes: Audit privilege documentation
Layer / File(s)
Summary
Document audit privileges privilege-management.md
The Dynamic privileges list describes AUDIT_ADMIN and RESTRICTED_AUDIT_ADMIN, the products that offer database audit logging, Essential’s Private Preview access requirement, and Starter’s exclusion.
The availability description may set incorrect expectations for Essential and Dedicated users. Correcting it is a bounded documentation follow-up.
Pre-merge checks: 5
Check name
Status
Explanation
Title check
The title names the two dynamic privileges added to privilege-management.md, which is the main change in the changeset. It is specific and follows the repository's convention of a file-scope prefix fo…
Description check
The description fills the required 'What is changed, added, or deleted' section with the privileges, their scope (SEM enabled and disabled), and the products where they are available. The version chec…
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title names the two dynamic privileges added to privilege-management.md, which is the main change in the changeset. It is specific and follows the repository's convention of a file-scope prefix followed by a short description.
Full details: Description check
Explanation
The description fills the required 'What is changed, added, or deleted' section with the privileges, their scope (SEM enabled and disabled), and the products where they are available. The version checklist is completed for master and v8.5, and the translation source and AI agent involvement are stated. The first-time contributor checklist is omitted, which is acceptable because it applies only to first-time contributors. The related code change PR field is left blank, which is acceptable because the template marks it as applicable only when a code change exists.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Reviewing files that changed from the base of the PR and between 16b9550 and 7f0c66a.
Files selected for processing: 1
privilege-management.md
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed, added, or deleted? (Required)
Add the
AUDIT_ADMINandRESTRICTED_AUDIT_ADMINdynamic privileges to the dynamic privilege list inprivilege-management.md, and list the products where they are available: TiDB Enterprise, TiDB Cloud Dedicated, TiDB Cloud Premium, and TiDB Cloud Essential (database audit logging is in beta and available upon request). TiDB Cloud Starter does not support database audit logging.Both privileges control database audit log management: audit-related system variables, manual audit log rotation, and audit log filters/rules.
AUDIT_ADMINis required when SEM is disabled, andRESTRICTED_AUDIT_ADMINis required when SEM is enabled.Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
🤖 Generated with Claude Code
Summary by CodeRabbit