Repository navigation
Conversation
Add the seven UnReservedKeyword tokens that scripts/check-keywords.py reports as missing on master: ALERT, AUTO, FAST, IMMEDIATE, MATERIALIZED, OPERATE, and TRANSITIONS. Each entry is inserted in its alphabetical position and left unmarked, since all seven are alternatives of the UnReservedKeyword rule in pkg/parser/parser.y.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @sary8. Thanks for your PR. I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Add ASYNC, COMPARE, COMPLETE, DELTA, OUTPUT, PLACE, RESULT, RETURN, and VIEWS. The weekly keyword check now reports these nine UnReservedKeyword tokens as missing on master, in addition to the seven from the previous commit. Each entry is inserted in its alphabetical position without the (R) marker, since all nine are alternatives of the UnReservedKeyword rule in pkg/parser/parser.y.
What is changed, added, or deleted? (Required)
Add the
ALERT,ASYNC,AUTO,COMPARE,COMPLETE,DELTA,FAST,IMMEDIATE,MATERIALIZED,OPERATE,OUTPUT,PLACE,RESULT,RETURN,TRANSITIONS, andVIEWSnon-reserved keywords tokeywords.mdso it matches the TiDBmasterparser. All 16 are alternatives of theUnReservedKeywordrule inpkg/parser/parser.y, andscripts/check-keywords.pypasses against themasterparser with them added.This PR first added seven of them. Later runs of the weekly check reported the other nine.
Fixes #24661. This PR also closes #24604, closes #24546, closes #24478, closes #24430, closes #24150, closes #23974, closes #23915, closes #23846, closes #23750, and closes #23670. They are earlier runs of the same weekly check, and each reports a subset of these 16 keywords.
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
None of the 16 keywords is in the
release-8.5parser, and the weekly check reports that branch as passing, so I didn't add a cherry-pick label.What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit
ALERT,ASYNC,AUTO,COMPARE,COMPLETE,DELTA,FAST,IMMEDIATE,MATERIALIZED,OPERATE,OUTPUT,PLACE,RESULT,RETURN,TRANSITIONS, andVIEWS.