Repository navigation
fix: treat If-Match: * as satisfied when etag is disabled - #317
Merged
blakeembrey merged 1 commit intoNov 10, 2026
Merged
Conversation
blakeembrey
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
etag: false, a request carryingIf-Match: *for a file that exists gets 412 Precondition Failed. RFC 9110 section 13.1.1 says*is true whenever the server has a current representation, so it doesn't depend on an ETag being present. With the defaultetag: truethe same request already gets 200.The fix checks for
*before looking at the ETag header, so a missing ETag only fails the precondition when the client lists actual entity tags.I added a test under "where If-Match is set" that makes this request with
etag: false. On master it fails withError: expected 200 "OK", got 412 "Precondition Failed". With the fix all 140 tests pass (npm testandnpm run test-ci), andnpm run lintis clean.