Skip to content

Update DPD api with non-functional breaking changes - #1024

Draft
cfzimmerman wants to merge 1 commit into
mainfrom
cory/dendrite-progenitor16
Draft

cfzimmerman wants to merge 1 commit into
mainfrom
cory/dendrite-progenitor16

Conversation

@cfzimmerman

Copy link
Copy Markdown

This addresses breaking changes in DPD's API following two recent ~cosmetic changes:

- progenitor v0.16
- openapi lint
@cfzimmerman
cfzimmerman added this pull request to stack #1026 November 18, 2026 01:12
@cfzimmerman

Copy link
Copy Markdown
Author

@claude review

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is a mechanical dendrite dependency bump, and the code changes only adapt to the regenerated client's API.

What was reviewed:

  • Every Client::new call site for dpd in ddm/src/sys.rs, falcon-lab and mg-lower. Each one now handles the Result. The ddm add and remove paths log the error and return, which matches how they already handle per-route errors. The mgd .expect() gives the same panic-on-failure behavior the old constructor had.
  • The illumos-only new_dpd_client. Its body returns the Result directly, and its only caller is mgd/src/main.rs. Both crates use reqwest 0.13, the same version as dpd-client, so the reqwest::Result signature lines up.
  • The Rear/Qsfp try_from(&str) changes, and Cargo.lock, which changes only the dendrite rev, the progenitor/dropshot versions and the crc8 removal.
Extended reasoning...

The PR moves the dendrite git rev forward in Cargo.toml and Cargo.lock and adapts 4 Rust files to the regenerated dpd-client API: a fallible Client::new and &str-based TryFrom for port IDs. It touches no security-sensitive surface such as auth, crypto or permissions. Every changed call site was checked, and the error handling either keeps the old behavior or is more graceful. The repository has no CODEOWNERS file, and the timeline shows no outstanding reviewer objections. The change is small and mechanical with clear intent, so approval is appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant