Repository navigation
Update DPD api with non-functional breaking changes - #1024
Draft
cfzimmerman wants to merge 1 commit into
Draft
cfzimmerman wants to merge 1 commit into
cfzimmerman wants to merge 1 commit into
Conversation
- progenitor v0.16 - openapi lint
Author
|
@claude review |
There was a problem hiding this comment.
LGTM. This is a mechanical dendrite dependency bump, and the code changes only adapt to the regenerated client's API.
What was reviewed:
- Every
Client::newcall site for dpd in ddm/src/sys.rs, falcon-lab and mg-lower. Each one now handles theResult. The ddm add and remove paths log the error and return, which matches how they already handle per-route errors. The mgd.expect()gives the same panic-on-failure behavior the old constructor had. - The illumos-only
new_dpd_client. Its body returns theResultdirectly, and its only caller is mgd/src/main.rs. Both crates use reqwest 0.13, the same version as dpd-client, so thereqwest::Resultsignature lines up. - The
Rear/Qsfptry_from(&str)changes, and Cargo.lock, which changes only the dendrite rev, the progenitor/dropshot versions and the crc8 removal.
Extended reasoning...
The PR moves the dendrite git rev forward in Cargo.toml and Cargo.lock and adapts 4 Rust files to the regenerated dpd-client API: a fallible Client::new and &str-based TryFrom for port IDs. It touches no security-sensitive surface such as auth, crypto or permissions. Every changed call site was checked, and the error handling either keeps the old behavior or is more graceful. The repository has no CODEOWNERS file, and the timeline shows no outstanding reviewer objections. The change is small and mechanical with clear intent, so approval is appropriate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses breaking changes in DPD's API following two recent ~cosmetic changes: