Repository navigation
kolla: Pass the host list in a file - #2979
Merged
Merged
Conversation
collect-kolla-logs.yml printed its fallback notice to stderr and looped over the stdout lines of the host discovery task. Zuul's command module merges stderr into stdout unless a job sets ansible-split-streams, so in CI the notice ended up in the host list. When "osism get hosts" yielded nothing, the health and copy loops word-split "'osism get hosts' yielded no hosts, falling back to /opt/configuration/inventory/10-custom" and ran ssh against "yielded", "no", "falling", ... before the real hosts. The copy loop also left a stray kolla/opt/configuration/ directory in the uploaded logs, because rmdir removed only the leaf of the path it created. An ssh or awk error from the manager would have been treated the same way. The discovery task now writes the host list to a file, and the loops take it from there, so stdout carries only messages in both stream modes. The notice goes to stdout, and the discovery output is printed with the copy summary, so a local run and a Zuul run report it the same way. The summary also runs when no host was found, so the job output shows why nothing was collected. Assisted-by: Claude:claude-opus-5-5 Signed-off-by: Roger Luethi <luethi@osism.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
collect-kolla-logs.yml(from #2977) printed its fallback notice to stderr and looped over the stdout lines of the host discovery task. Zuul'scommandmodule merges stderr into stdout unless a job setsansible-split-streams, and the testbed jobs don't set it. In CI the notice therefore landed in the host list.When
osism get hostsyielded nothing, the container health and log copy loops word-split the notice and ran ssh againstosism,yielded,no,falling,back,toand/opt/configuration/inventory/10-custombefore the real hosts. The copy loop also left a straykolla/opt/configuration/directory in the uploaded logs. An ssh or awk error from the manager would have been treated the same way. Seen in build cd1702dd (testbed-deploy-next-in-a-nutshell-with-tempest-ubuntu-24.04, periodic).Change
slurptask reads it back, and the loops take their hosts from there. Stdout now carries only messages, whichever stream mode the job runs in.Testing
zuul-label run would skip it; covering it needs a failing build.🤖 Generated with Claude Code