Skip to content

Remove sources for Hungarian school holidays - #696

Merged
KristjanESPERANTO merged 1 commit into
opening-hours:mainfrom
urbalazs:hun-sources-261009
Oct 10, 2026
Merged

KristjanESPERANTO merged 1 commit into
opening-hours:mainfrom
urbalazs:hun-sources-261009

Conversation

@urbalazs

@urbalazs urbalazs commented Oct 9, 2026

Copy link
Copy Markdown

The data and the sources have already been migrated to openholidaysapi.

You can see the sources in its documentation. They are no longer needed here.

@KristjanESPERANTO

Copy link
Copy Markdown
Member

Thanks for this cleanup! I rebased your commit and adjusted its commit message to our convention.

@KristjanESPERANTO
KristjanESPERANTO merged commit 457b0d2 into opening-hours:main Oct 10, 2026
7 checks passed
@KristjanESPERANTO

Copy link
Copy Markdown
Member

@urbalazs May I take this opportunity to ask you something about the public holidays? 🙂

I'm currently working on moving the public holiday data to date-holidays and reconciling the two datasets. If I adopt the date-holidays data for Hungary as-is, some things would change for Hungary. You can see them in this commit (not merged yet): KristjanESPERANTO@d08e1d3

Could you please review the changes and let me know if they look right, or if we need to make adjustments upstream in date-holidays?

@urbalazs

Copy link
Copy Markdown
Author

Could you please review the changes and let me know if they look right, or if we need to make adjustments upstream in date-holidays?

Please use the list of holidays as is in src/holidays/hu.yaml

The names starts with lowercase letters.

Sources to approve:

(1) Magyarország nemzeti ünnepei:
a) március 15. napja, az 1848–49. évi forradalom és szabadságharc emlékére;
b) augusztus 20. napja, az államalapítás és az államalapító Szent István király emlékére;
c) október 23. napja, az 1956. évi forradalom és szabadságharc emlékére.

Munkaszüneti nap: január 1., március 15., nagypéntek, húsvéthétfő, május 1., pünkösdhétfő, augusztus 20., október 23., november 1. és december 25–26.

@urbalazs
urbalazs deleted the hun-sources-261009 branch October 12, 2026 08:53
@KristjanESPERANTO

Copy link
Copy Markdown
Member

Thanks for clarifying the naming convention. I'm preparing a PR for date-holidays.

I found three different wordings for these national holidays:

Date Current date-holidays name opening_hours.js name Wording in Article J(1)
03-15 1848-as forradalom az 1848-as forradalom ünnepe március 15. napja, az 1848–49. évi forradalom és szabadságharc emlékére
08-20 Szent István ünnepe az államalapítás ünnepe augusztus 20. napja, az államalapítás és az államalapító Szent István király emlékére
10-23 1956-os forradalom az 1956-os forradalom ünnepe október 23. napja, az 1956. évi forradalom és szabadságharc emlékére

The wording in Article J(1) is from the Fundamental Law of Hungary. I don't speak Hungarian, so I can't judge these names or derive shorter forms. Which wording would you recommend using?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants