Repository navigation
Conversation
Existing filter tests cover restricted permissions and explicit device numbers separately, but not together. Combine them to exercise the maximum eight-instruction rule block. Use two distinct devices in both allow-list and deny-list modes to check jumps to the next rule and the final default action. Reuse testDeviceFilter to verify the generated instructions in both byte orders. Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
mfrw
commented
Nov 18, 2026
mfrw
left a comment
Contributor
Author
There was a problem hiding this comment.
/cc @thaJeztah addressing this copilot review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Existing filter tests cover restricted permissions and explicit device
numbers separately, but not together. Combine them to exercise the
maximum eight-instruction rule block.
Use two distinct devices in both allow-list and deny-list modes to
check jumps to the next rule and the final default action. Reuse
testDeviceFilter to verify the generated instructions in both byte
orders.
Signed-off-by: Muhammad Falak R Wani falakreyaz@gmail.com
Related: opencontainers/runc#5612