Skip to content

devices: test jumps across full-length filter rules - #100

Open
mfrw wants to merge 1 commit into
opencontainers:mainfrom
mfrw:mfrw/add-tests
Open

mfrw wants to merge 1 commit into
opencontainers:mainfrom
mfrw:mfrw/add-tests

Conversation

@mfrw

@mfrw mfrw commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

Existing filter tests cover restricted permissions and explicit device
numbers separately, but not together. Combine them to exercise the
maximum eight-instruction rule block.

Use two distinct devices in both allow-list and deny-list modes to
check jumps to the next rule and the final default action. Reuse
testDeviceFilter to verify the generated instructions in both byte
orders.

Signed-off-by: Muhammad Falak R Wani falakreyaz@gmail.com

Related: opencontainers/runc#5612

Existing filter tests cover restricted permissions and explicit device
numbers separately, but not together. Combine them to exercise the
maximum eight-instruction rule block.

Use two distinct devices in both allow-list and deny-list modes to
check jumps to the next rule and the final default action. Reuse
testDeviceFilter to verify the generated instructions in both byte
orders.

Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
@mfrw
mfrw requested a review from a team as a code owner November 18, 2026 07:32

@mfrw mfrw left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @thaJeztah addressing this copilot review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant