Repository navigation
feat(rmf_demos_tasks): add configurable timeout and non-zero exit codes - #371
Open
muskan-creates352 wants to merge 1 commit into
Open
muskan-creates352 wants to merge 1 commit into
muskan-creates352 wants to merge 1 commit into
Conversation
Add an optional --timeout CLI argument (default: 5.0s) to all task dispatch and request scripts in rmf_demos_tasks. Also ensure scripts exit with non-zero exit code (sys.exit(1)) when timing out or failing, preventing silent failures in CI/automation workflows. Fixes open-rmf#370 Signed-off-by: Muskan Kumari <er.muskan09@gmail.com>
aaronchongth
requested changes
Nov 9, 2026
aaronchongth
left a comment
Member
There was a problem hiding this comment.
Before the team starts reviewing, please fill up the declaration of whether generative AI was used
Author
|
Updated the description with the GenAI declaration! @aaronchongth |
1 of 2 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature / Enhancement
Linked Issue
Fixes #370
Description of changes
Currently, task dispatch and request scripts in
rmf_demos_taskshave a hardcoded5.0stimeout and exit with return code0even when no response is received from the dispatcher node.This PR implements:
--timeoutCLI argument (default:5.0seconds) to all task dispatch and request CLI tools inrmf_demos_tasks.sys.exit(1)) on timeout or failure, ensuring automated test harnesses, shell scripts, and CI workflows can properly detect dispatch failures.Testing
--helpdisplays--timeoutacross all updated scripts.pycodestyle rmf_demos_taskspasses with 0 errors).GenAI Use
We follow OSRA's policy on GenAI tools
Tool used: Google Antigravity