Skip to content

Fix typo and stray whitespace in fleet adapter messages - #229

Merged
aaronchongth merged 1 commit into
open-rmf:mainfrom
Lots-ninety-nine:fix/log-message-typos
Oct 21, 2026
Merged

aaronchongth merged 1 commit into
open-rmf:mainfrom
Lots-ninety-nine:fix/log-message-typos

Conversation

@Lots-ninety-nine

Copy link
Copy Markdown
Contributor

Bug fix

Fixed bug

Two small message fixes in fleet_adapter.py, no issue since they're just typos:

  • The log in update_robot() says "Failed to pose of robot", missing "get".
  • The assert message after add_easy_fleet() breaks the string with a backslash inside the quotes, so the message ends up with 8 spaces of indentation in the middle.

Fix applied

Added "get", and split the assert message into two string literals. No behavior change. I checked both messages by running the code before and after (missing TF for the pose log, a graph with duplicate dock names for the assert), 3 times each.

New feature implementation

Implemented feature

N/A, this is a bug fix.

Implementation description

N/A, this is a bug fix.

GenAI Use

We follow OSRA's policy on GenAI tools

  • I used a GenAI tool in this PR.
  • I did not use GenAI

Generated-by: AI found the typos and made the edits; I reviewed it before submitting.
Assisted-by: Cursor

Assisted-by: Cursor

Signed-off-by: Mosiwon <Lots-ninety-nine@users.noreply.github.com>
@codecov

codecov Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 64.05%. Comparing base (82b1a5c) to head (7d716fc).

Files with missing lines Patch % Lines
..._fleet_adapter/free_fleet_adapter/fleet_adapter.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #229   +/-   ##
=======================================
  Coverage   64.05%   64.05%           
=======================================
  Files          10       10           
  Lines        1202     1202           
  Branches      166      166           
=======================================
  Hits          770      770           
  Misses        400      400           
  Partials       32       32           
Flag Coverage Δ
tests 64.05% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aaronchongth aaronchongth left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@aaronchongth
aaronchongth merged commit d5733b6 into open-rmf:main Oct 21, 2026
11 checks passed
@github-project-automation github-project-automation Bot moved this from Inbox to Done in PMC Board Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants