Repository navigation
Conversation
A package.json whose "main" entry cannot be resolved no longer falls back to the package's top-level index file when loaded with require(). Instead, a MODULE_NOT_FOUND error is thrown, matching the existing behavior for packages that have no index file. This has been a runtime deprecation since v16.0.0. Refs: nodejs#37204 Refs: nodejs#26823 Assisted-by: Claude Signed-off-by: James M Snell <jasnell@gmail.com>
Collaborator
|
Review requested:
|
jasnell
commented
Nov 15, 2026
panva
approved these changes
Nov 15, 2026
This comment was marked as outdated.
This comment was marked as outdated.
GeoffreyBooth
approved these changes
Nov 15, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #67487 +/- ##
==========================================
- Coverage 90.67% 90.66% -0.01%
==========================================
Files 799 799
Lines 280245 280235 -10
Branches 54125 54120 -5
==========================================
- Hits 254100 254075 -25
- Misses 16280 16288 +8
- Partials 9865 9872 +7
🚀 New features to boost your workflow:
|
Member
Author
|
@nodejs/tsc ... will need another sign off here |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A package.json whose "main" entry cannot be resolved no longer falls back to the package's top-level index file when loaded with require(). Instead, a MODULE_NOT_FOUND error is thrown, matching the existing behavior for packages that have no index file.
This has been a runtime deprecation since v16.0.0.
Refs: #37204
Refs: #26823