Skip to content

feature: Non-deferred Function calls #495

Closed

Description

@joshperry

The current Function::Call is soon to be deprecated and directs embedders to the new overload that takes a Context (usually retrieved from the current isolate?) and returns a MaybeLocal.

Nan currently provides a way to make deferred calls to JS functions in a V8/node version independent manner (through Nan::Callback which uses node::MakeCallback).

It would be nice for Nan to have a primitive for making non-deferred js function calls for when the original Call overload is finally deprecated and removed.

Activity

  1. joshperry commented on Oct 15, 2015

    @joshperry
    Author

    See the discussion that I improperly started in #284

  2. kkoopa commented on Oct 15, 2015

    @kkoopa
    Collaborator

    The old Function::Call is already removed. #496

  3. joshperry commented on Oct 15, 2015

    @joshperry
    Author

    @kkoopa Ah cool. Thanks for that!

    Hope starting that conversation over there didn't cause too much confusion :/ kind of new in this neck of the woods.

  4. kkoopa commented on Oct 15, 2015

    @kkoopa
    Collaborator

    No problem. However, you'll want to patch your own code until this is released, which will be when there are enough new features to warrant a new release, maybe in a month or two.

    On October 15, 2015 7:34:19 PM GMT+03:00, Joshua Perry notifications@github.com wrote:

    @kkoopa Ah cool. Thanks for that!

    Hope starting that conversation over there didn't cause too much
    confusion :/ kind of new in this neck of the woods.


    Reply to this email directly or view it on GitHub:
    #495 (comment)

  5. joshperry commented on Oct 15, 2015

    @joshperry
    Author

    Not a prob. Was just hoping to make the future better for everyone!

    Thank you again for your help.

  6. kkoopa commented on Oct 15, 2015

    @kkoopa
    Collaborator

    Good, thanks for reporting this. I had completely missed it.

    On October 15, 2015 7:42:11 PM GMT+03:00, Joshua Perry notifications@github.com wrote:

    Not a prob. Was just hoping to make the future better for everyone!

    Thank you again for your help.


    Reply to this email directly or view it on GitHub:
    #495 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions