chore: move to wrangler for deployments - #1026
avivkeller wants to merge 3 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🚀 Deploying Preview to Cloudflare 🚀Preview Deployments by commit
|
This comment was marked as outdated.
This comment was marked as outdated.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1026 +/- ##
==========================================
- Coverage 92.60% 92.47% -0.13%
==========================================
Files 244 246 +2
Lines 22998 23030 +32
Branches 2250 2250
==========================================
Hits 21297 21297
- Misses 1692 1724 +32
Partials 9 9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@avivkeller could you add a PR description 🙇 |
df8c1cd to
d4c7114
Compare
ovflowd
left a comment
There was a problem hiding this comment.
@avivkeller I talked with some folks from Cloudflare, they asked us to try their new cf CLI instead of Wrangler -- can we give that a try?
Can we not do this? |
Im fine either way, but they said the |
There was a problem hiding this comment.
I suppose this is not needed anymore?
| htmlHandling: 'auto-trailing-slash', | ||
| notFoundHandling: '404-page', | ||
| }, | ||
| domains: [mode === 'beta' ? 'beta.docs.nodejs.org' : 'doc-kit.nodejs.org'], |
There was a problem hiding this comment.
instead of mode, can simply allow the domain be passed via process.env?
|
@avivkeller let me update the CLI command to CF on Cloudflare Dashboard for the Preview Deployments -- Ill do that once this PR is ready, to test that out tho. |
There was a problem hiding this comment.
Does this mean the repo root would be /scripts/deployments? Shouldn't we... hmmm, have deployments be apps? like we have on nodejs.org repo?
That's fair, but I'd rather wait until it is stable and proven before we switch over to it. And when we do switch, I'd like to switch all our projects at once, so folks aren't having to maintain the mental overhead of two different toolchains depending on which project you're working on. |
|
I'm indifferent to which one we use, but it's worth noting that doc-kit is kind of a testing playground, so I'm not super concerned with using a beta tool |
No description provided.