Repository navigation
Fix 2DGS rasterization with several cameras per call - #1099
Open
nicolaihaeni wants to merge 1 commit into
Open
nicolaihaeni wants to merge 1 commit into
nicolaihaeni wants to merge 1 commit into
Conversation
Opacities were expanded over the C cameras without a copy, and the 2DGS rasterizer rejects the
non-contiguous result ("opacities must be contiguous") for C > 1. Make it contiguous, as the 3DGS path
does before its kernels. A 2-camera call now matches two 1-camera calls exactly (outputs) and to ~1e-7
relative L2 (gradients).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With more than one camera per call, rasterization_2dgs expands the opacities over the cameras without a copy, and the 2DGS rasterizer rejects the non-contiguous result:
RuntimeError: opacities must be contiguous
This makes the expanded opacities contiguous, as the 3DGS path does before its kernels. Checked: a 2-camera call now gives exactly the same outputs as two 1-camera calls, and gradients within ~1e-7 relative L2.
Repro (fails on main in the forward):