Repository navigation
simple_trainer: only pass fused=True to torch.optim.Adam (fixes --visible_adam / --sparse_grad) - #1086
Open
kleinicke wants to merge 1 commit into
Open
simple_trainer: only pass fused=True to torch.optim.Adam (fixes --visible_adam / --sparse_grad)#1086kleinicke wants to merge 1 commit into
kleinicke wants to merge 1 commit into
Conversation
Since b60e917 (set default adam to fused) --visible_adam and --sparse_grad crash when the optimizers are built: SelectiveAdam.__init__() and SparseAdam.__init__() got an unexpected keyword argument 'fused'. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since b60e917 ("set default adam to fused"),
create_splats_with_optimizerspassesfused=Trueto every optimizer class. Onlytorch.optim.Adamaccepts it, so--visible_adamand--sparse_gradcrash before the first step:This PR passes
fused=Trueonly when the class istorch.optim.Adam, so the default path is unchanged.