Skip to content

Neutral header comments in tstfabnd, tstx37, tstnospc (#724) - #739

Merged
mgrossmann merged 1 commit into
mainfrom
chore/neutral-test-headers-724
Oct 27, 2026
Merged

mgrossmann merged 1 commit into
mainfrom
chore/neutral-test-headers-724

Conversation

@mgrossmann

Copy link
Copy Markdown
Contributor

Closes #724.

Same defect as #718: three test header comments named a private test system, measurement dates, job numbers, a consuming project and its console messages. The failure is now described in words; only the IEC031I D37-04 line remains. The two inline comments in tstx37.c and tstnospc.c that named the consumer are reworded too.

Comment-only change, no test code touched.

Test plan

  • git diff shows comment lines only
  • make test-host gives the same result as on main (23 host tests do not build in the local environment either way)
  • CI green

The comments named a private test system, measurement dates, job numbers
and a consuming project with its console messages. Describe the failure
in words instead; only the IEC031I D37-04 line stays. Comments only, no
change to the test code.
@mgrossmann mgrossmann added this to the 2.27.0 milestone Oct 27, 2026
@sonarqubecloud

Copy link
Copy Markdown

@mgrossmann

Copy link
Copy Markdown
Contributor Author

Review of #739 (closes #724).

  • Comment-only: I stripped comments from all three files at base and head and compared the results; the code is identical in test/host/tstfabnd.c, test/mvs/tstx37.c and test/mvs/tstnospc.c. The diff touches nothing else (3 files, +27/-26).
  • Neutrality: a grep over the three files at the PR head finds no ftpd, mvsdev, WORK00, job numbers, dates, #129 or ftpd console messages (FTPD0xx). The only console line left is IEC031I D37-04, as intended. The two inline comments (/* the free catalogs it */) are reworded too.
  • The reworded text still reads correctly and keeps the technical content (SPACE=TRK(1,0), the before/after map, the 200 records of 80).
  • CI: build, host-tests, manuals (typst), package, SonarCloud and the Read the Docs build all pass.

Not tested: the MVS tests (tstx37, tstnospc) were not run; the change does not touch code, so I did not see a need.

APPROVE

@mgrossmann
mgrossmann merged commit db1880f into main Oct 27, 2026
7 checks passed
@mgrossmann
mgrossmann deleted the chore/neutral-test-headers-724 branch October 27, 2026 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test/host/tstfabnd.c: header comment names a private system, a date and consumer messages

1 participant